Tests: Fix the "outside view position" test in Headless Chrome#5728
Merged
mgol merged 1 commit intojquery:mainfrom Nov 24, 2025
Merged
Tests: Fix the "outside view position" test in Headless Chrome#5728mgol merged 1 commit intojquery:mainfrom
mgol merged 1 commit intojquery:mainfrom
Conversation
In Headless Chrome, when run locally on macOS together with a few other modules, the scroll handler for the appended element in the "outside view position" dimensions test doesn't fire, timing out the test & failing it as a result. While the scroll handler may not fire, the new position data is available immediately, so just do the checks directly, without relying on scroll handlers.
timmywil
approved these changes
Nov 24, 2025
Member
timmywil
left a comment
There was a problem hiding this comment.
LGTM. Strange that it only happens when run with other modules, but we may as well make the tests simpler.
mgol
added a commit
that referenced
this pull request
Nov 24, 2025
In Headless Chrome, when run locally on macOS together with a few other modules, the scroll handler for the appended element in the "outside view position" dimensions test doesn't fire, timing out the test & failing it as a result. While the scroll handler may not fire, the new position data is available immediately, so just do the checks directly, without relying on scroll handlers. Closes gh-5729 Ref gh-5728
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In Headless Chrome, when run locally on macOS together with a few other modules, the scroll handler for the appended element in the "outside view position" dimensions test doesn't fire, timing out the test & failing it as a result.
While the scroll handler may not fire, the new position data is available immediately, so just do the checks directly, without relying on scroll handlers.
3.xversion: gh-5729Ref gh-5729
Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com