Release: Run npm publish in the post-release phase
#5690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmywil
requested changes
Aug 11, 2025
PR jquerygh-5681 specified the `tmp/release/dist` folder as `publishPath` so that `npm publish` is done from the dist repo, not the source one. However, `npm publish` is invoked by release-it before the post-release phase, at which stage the dist repo is not updated with the new release yet. Instead, do the `npm publish` manually in the post-release stage, just after the dist repo is updated & changes are pushed.
437b72f to
a2a2102
Compare
timmywil
approved these changes
Aug 11, 2025
mgol
added a commit
that referenced
this pull request
Aug 11, 2025
PR gh-5681 specified the `tmp/release/dist` folder as `publishPath` so that `npm publish` is done from the dist repo, not the source one. However, `npm publish` is invoked by release-it before the post-release phase, at which stage the dist repo is not updated with the new release yet. Instead, do the `npm publish` manually in the post-release stage, just after the dist repo is updated & changes are pushed. Closes gh-5690 (cherry picked from commit ff1f0ea)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR gh-5681 specified the
tmp/release/distfolder aspublishPathso thatnpm publishis done from the dist repo, not the source one. However,npm publishis invoked by release-it before the post-release phase, at which stage the dist repo is not updated with the new release yet.Instead, do the
npm publishmanually in the post-release stage, just after the dist repo is updated & changes are pushed.Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com