Tests: migrate test runner to jquery-test-runner#5604
Merged
Conversation
- this might fix an error on Windows pertaining to esm
mgol
reviewed
Jan 2, 2025
mgol
left a comment
Member
There was a problem hiding this comment.
Code-wise looks good but where is the runner code? https://www.npmjs.com/package/jquery-test-runner points to https://github.com/jquery/jquery-test-runner which is a 404 to me. I should be seeing all the repos in the org with my permissions.
Member
Author
|
Member
|
@timmywil Can you move the repo and add me ( |
mgol
approved these changes
Jan 13, 2025
mgol
left a comment
Member
There was a problem hiding this comment.
Approving to unblock you but please remember about adding the owners to the runner package!
This was referenced Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I've moved all the code from
test/runnerinto a package called jquery-test-runner. The changes to this repo are fairly simple. It uses the binary included in that package to run tests in browsers using selenium and browserstack.Some things to note:
jtr(alias forjquery-test-runner) binary includes several commands. The default command is for test runs (jtrorjtr run). jtr also includesjtr serve, which has a-p(--port) option (rather than an env var). Seenpx jtr --helpfor all commands and options.jquery-test-runner.test/runnerfolder, which means the recent changes to allow Edge runs in IE-mode have been kept,expressis not used for the test server, etc. jquery-migrate and jquery-ui will now be able to take advantage of those changes.jquery-test-runnercan take a YAML config file, with support for all of the same options as the command line. I considered JSON and JS, but I liked how terse the YAML was. See jtr-isolate.yml for an example, which is used to create a separate run for each module in BrowserStack runs while still sharing browser instances.Once we merge this to
jquery, I'll make PRs forjquery-migrateandjquery-ui.At some point, we can move jquery-test-runner over to the jquery org.movedChecklist