adding support for compressed payloads#753
Merged
auvipy merged 8 commits intojpadilla:masterfrom May 19, 2022
Merged
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
auvipy
approved these changes
May 19, 2022
Owner
|
Is this something we can instead provide some kind of hook for? This seems kinda specific use case that I’d think would better live outside this lib |
Owner
|
@auvipy let's revert this please. I'd like to think it through a bit more. Sorry for the last minute comments. |
Collaborator
|
I am going to revert this for now, but supporting compressed payload may be a future endeaviour |
Contributor
|
It's strange that this was merged when #666 is pending to do the same thing. |
auvipy
added a commit
that referenced
this pull request
May 23, 2022
Owner
|
@jpadilla Gan you give some update if there is already a way for some sort of callback that can be passed to do this? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of US states are using Smart Health Cards (https://smarthealth.cards/en/) to issue digital proof of COVID-19 vaccination. The QR code on the certificate decodes to a JWT token, but it has a compressed payload and upstream PyJWT didn't handle it. So I offer this contribution.
This patch introduces a dependency on
zlibbut as an old, salty python developer who hasn't lifted myself out of the requirements.txt era, I haven't figured out how this project is managing dependencies. Can you help me understand what needs to be done?