Use define instead of #![deny(warning)]#1290
Merged
christian-schilling merged 1 commit intomasterfrom Nov 4, 2023
Merged
Conversation
a473b2b to
4b39a3c
Compare
4b39a3c to
a6216f0
Compare
Setting #![deny(warnings) in the source can cause josh fail to build on different versions of rustc. This way we only ensure there are no warnings on our "officially supported" rustc version, but allow building on other versions as well. Change: warnings
a6216f0 to
65946b2
Compare
13 tasks
christian-schilling
added a commit
that referenced
this pull request
Oct 11, 2025
Setting #![deny(warnings) in the source can cause josh fail to build on different versions of rustc. This way we only ensure there are no warnings on our "officially supported" rustc version, but allow building on other versions as well. Change: warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting #![deny(warnings) in the source can cause josh fail to build on different versions of rustc.
This way we only ensure there are no warnings on our "officially supported" rustc version, but allow building on other versions as well.
Change: warnings