Skip to content

Add completions for move command#18

Merged
joseluisq merged 2 commits intojoseluisq:masterfrom
ivaaaan:fish-completions
Aug 18, 2020
Merged

Add completions for move command#18
joseluisq merged 2 commits intojoseluisq:masterfrom
ivaaaan:fish-completions

Conversation

@ivaaaan
Copy link

@ivaaaan ivaaaan commented Aug 18, 2020

Hey. I really like the plugin and would like to contribute. Let me know if it needs more completions or I need to add sth else

@joseluisq joseluisq self-assigned this Aug 18, 2020
@joseluisq joseluisq added the enhancement New feature or request label Aug 18, 2020
@joseluisq
Copy link
Owner

Sure, completions are a missing feature so feel free to contribute with more ones.

@joseluisq
Copy link
Owner

Have you tried to install it? I got errors

~> fisher add ivaaaan/gitnow@fish-completions
linking ~/.config/fish/functions/__gitnow_config_file.fish
linking ~/.config/fish/functions/__gitnow_functions.fish
linking ~/.config/fish/functions/__gitnow_manual.fish
linking ~/.config/fish/completions/__gitnow_completions.fish
linking ~/.config/fish/conf.d/gitnow.fish
linking ~/.config/fish/conf.d/gitnow_config.fish
source: Error encountered while sourcing file '/completions/__gitnow_completions.fish':
source: No such file or directory
source: Error encountered while sourcing file '/completions/__gitnow_completions.fish':
source: No such file or directory
source: Error encountered while sourcing file '/completions/__gitnow_completions.fish':
source: No such file or directory
source: Error encountered while sourcing file '/completions/__gitnow_completions.fish':
source: No such file or directory
source: Error encountered while sourcing file '/completions/__gitnow_completions.fish':
source: No such file or directory
source: Error encountered while sourcing file '/completions/__gitnow_completions.fish':
source: No such file or directory
source: Error encountered while sourcing file '/completions/__gitnow_completions.fish':
source: No such file or directory
fetching https://codeload.github.com/fishpkg/fish-segment/tar.gz/master
fetching https://codeload.github.com/fishpkg/fish-pwd-info/tar.gz/master
fetching https://codeload.github.com/fishpkg/fish-git-util/tar.gz/master
fetching https://codeload.github.com/fishpkg/fish-pwd-is-home/tar.gz/master

@ivaaaan
Copy link
Author

ivaaaan commented Aug 18, 2020

@joseluisq should be fine now.

@joseluisq joseluisq self-requested a review August 18, 2020 08:52
@joseluisq
Copy link
Owner

Fine, it works now.

@joseluisq joseluisq added this to the 2.5.0 milestone Aug 18, 2020
@joseluisq joseluisq merged commit 1376b89 into joseluisq:master Aug 18, 2020
@joseluisq
Copy link
Owner

Merged!
It's also included in future v2.5.0 but you can use this feature PR right now reinstalling GitNow from master branch.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants