Undefined index REMOTE_ADDR#23
Merged
mbabker merged 1 commit intojoomla-framework:masterfrom Jul 11, 2019
SharkyKZ:remoteAddr
Merged
Undefined index REMOTE_ADDR#23mbabker merged 1 commit intojoomla-framework:masterfrom SharkyKZ:remoteAddr
mbabker merged 1 commit intojoomla-framework:masterfrom
SharkyKZ:remoteAddr
Conversation
Contributor
Author
|
Is there something other than an empty string we should return when running in CLI? |
Contributor
|
There is no IP for a CLI process. Trying to fake it is inconsistent with PHP. |
Contributor
Author
|
OK, thanks. |
Contributor
|
@mbabker It seems the changes in this PR have not been merged up to the 2.0-dev branch yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #
Summary of Changes
Check that
$_SERVER['REMOTE_ADDR']is set.Testing Instructions
Use
IpHelper::workaroundIPIssues()orIpHelper::getIpin CLI.Expected Result
No notices.
Actual Result
Documentation Changes Required
No.