Accept the source data to be array in fromObject#12
Merged
mbabker merged 2 commits intojoomla-framework:masterfrom Sep 5, 2015
Merged
Accept the source data to be array in fromObject#12mbabker merged 2 commits intojoomla-framework:masterfrom
mbabker merged 2 commits intojoomla-framework:masterfrom
Conversation
in `fromObject()` we call the private function `arrayFromObject()` which is capable of handling arrays as well. Allowing an `array` as argument to `fromObject()` will not break anything **plus** it will convert any nested `object` type values in it appropriately and give desired result.
Contributor
|
Is this something you could add a test case for? |
Contributor
Author
|
Yes, I was about to ask that. Can you advise me that should I replicate every test seed with input type to be array, or just one of them would do? |
Contributor
|
Just one seed for the added case is all that's needed. |
Contributor
Author
|
I have update the test case for my changes. |
mbabker
added a commit
that referenced
this pull request
Sep 5, 2015
Accept the source data to be array in fromObject
Contributor
Author
|
It has been over six months and this repository is not pulled into the cms yet. I expected the changes to be a part of J3.5 already. |
Contributor
|
Tagged a release |
nibra
pushed a commit
that referenced
this pull request
Aug 14, 2022
Migrate old KeychainManager to joomla/console
nibra
pushed a commit
that referenced
this pull request
Aug 14, 2022
Modify array syntax covers setting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in
fromObject()we call the private functionarrayFromObject()which is capable of handling arrays as well. Allowing anarrayas argument tofromObject()will not break anything plus it will convert any nestedobjecttype values in it appropriately and give desired result.