Add possibility to override 'protected' item in Child container#48
Merged
laoneo merged 2 commits intojoomla-framework:3.x-devfrom May 23, 2023
Merged
Add possibility to override 'protected' item in Child container#48laoneo merged 2 commits intojoomla-framework:3.x-devfrom
laoneo merged 2 commits intojoomla-framework:3.x-devfrom
Conversation
Contributor
|
Happy with this but suggest we make isLocal protected or even private for now, we can always expand it to be more public later on but hard to make it more private |
wilsonge
approved these changes
May 22, 2023
Contributor
|
Thanks. Can you make a pr in the CMS repo with this update and a manual entry PR? |
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #47 but for 3.x branch
Pull Request for Issue joomla/joomla-cms#40324 and joomla/joomla-cms#40388
Summary of Changes
Allow to overide resource if it not exist locally
Testing Instructions
Unittest passes
Documentation Changes Required
New feature