Add possibility to override 'protected' item in Child container#47
Closed
Fedik wants to merge 2 commits intojoomla-framework:2.0-devfrom
Closed
Add possibility to override 'protected' item in Child container#47Fedik wants to merge 2 commits intojoomla-framework:2.0-devfrom
Fedik wants to merge 2 commits intojoomla-framework:2.0-devfrom
Conversation
4 tasks
laoneo
reviewed
May 8, 2023
Contributor
|
@Fedik can you rebase this one to 3.0-dev as it is a breaking change? |
Contributor
|
Nice tests, can you rebase to 3? |
Contributor
Author
|
Let it to decide by repository maintainers. It can be done at any time. |
Contributor
|
We discussed it in maintainers chat already and it is clear that it is a bc break so it has to go into 3. |
Contributor
Author
|
Changed, I will look in conflicts later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue joomla/joomla-cms#40324 and joomla/joomla-cms#40388
Summary of Changes
Allow to overide resource if it not exist locally
Testing Instructions
Unittest passes
Documentation Changes Required
New feature