[4.0] Fix adapting view categories to the core categories view#467
Merged
joomdonation merged 4 commits intojoomla-extensions:4.0-devfrom Oct 31, 2021
Merged
Conversation
Contributor
|
I tried to test this but when I applied the change here, the expand icon is displayed in wrong position. See the attached screenshot for Content Categories and Weblinks Categories:
Also, I think we should use a different css class for com_weblinks instead of using com-content-categories__items . Could you please think about it and find a solution? |
Contributor
Author
Contributor
|
So I tested it and it worked well. The reasons I have not merged this is because:
|
Contributor
Author
|
I suggest to merge this - it is better than now. weblinks categories are slightly different form content categories, but should be displayed now correctly. |
Contributor
|
OK. I trust you for layout stuffs. Let's move on :) ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Pull Request for Issue # .
Summary of Changes
Some changes were lost during lat commits.
This PR adapts again the view categories of weblinks to categories of content.
Testing Instructions
Make a tree of categories for example

Add description and image to categories as you like.
Add a menuitem of type categories to your menu
Expected result