Skip to content

Fix layout article categories list as tree#35114

Merged
bembelimen merged 1 commit intojoomla:4.0-devfrom
RickR2H:categories-layout
Nov 13, 2021
Merged

Fix layout article categories list as tree#35114
bembelimen merged 1 commit intojoomla:4.0-devfrom
RickR2H:categories-layout

Conversation

@RickR2H
Copy link
Copy Markdown
Member

@RickR2H RickR2H commented Aug 14, 2021

Pull Request for Issue # .
This is an addition to the PR #35093

Summary of Changes

Changed layout of categories list as tree. Also added an extra separator line on top of the first child

Testing Instruction

In the article categories, create some categories with some nested categories in it.
Add a description in every category and also add an image in the options tab.
Create a menu item of Articles -> List All Categories in an Article Category Tree
Make sure in the option tab that the categorie image and description are set to show.
To create the new CSS files run: npm run build:css

Actual result BEFORE applying this Pull Request

Image-3

Expected result AFTER applying this Pull Request

Image-4

Documentation Changes Required

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Aug 14, 2021
@RickR2H RickR2H changed the title Fix layout Fix layout article categories list as tree Aug 14, 2021
@joomdonation
Copy link
Copy Markdown
Contributor

Thanks @RickR2H . Not having good experience with frontend code but could we have a way to re-use the css code here for other extensions ?

We have other components like com_contact, com_weblinks, com_newsfeeds use the same structure, so if we can use a generic class name instead of hardcode it to com_content, that would be better.

@RickR2H
Copy link
Copy Markdown
Member Author

RickR2H commented Aug 14, 2021

@joomdonation Yes it's generic and is on my todo list. If I find some time I'll try to implement the solution. @drmenzelit the animation in the accordion is gone by the way. Was this intended?

@ChristineWk
Copy link
Copy Markdown

ChristineWk commented Aug 14, 2021

I have tested this item ✅ successfully on a2033a7

It's nicer now as in previous PR :-)

@RickR2H What do you mean with: "the animation in the accordion is gone by the way."


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35114.

Rick: Bedankt hoor, leuk geworden zeg, he, he :-)

@ChristineWk
Copy link
Copy Markdown

Result:

screen shot 2021-08-14 at 14 47 42


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35114.

@drmenzelit
Copy link
Copy Markdown
Collaborator

@joomdonation Yes it's generic and is on my todo list. If I find some time I'll try to implement the solution. @drmenzelit the animation in the accordion is gone by the way. Was this intended?

The animation was probably part of Bootstrap. I was looking for a generic solution without Bootstrap so I didn't payed attention at that

@ricardo1709
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on a2033a7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35114.

@richard67 richard67 removed PR-4.0-dev NPM Resource Changed This Pull Request can't be tested by Patchtester labels Aug 24, 2021
@richard67
Copy link
Copy Markdown
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35114.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 24, 2021
@richard67 richard67 added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Aug 24, 2021
@RickR2H
Copy link
Copy Markdown
Member Author

RickR2H commented Oct 17, 2021

@wilsonge Could you please take a look at this PR?

@chmst
Copy link
Copy Markdown
Contributor

chmst commented Oct 17, 2021

joomla-extensions/weblinks#467 (comment) @joomdonation similiar in PR in com_weblinks

@bembelimen bembelimen merged commit b487384 into joomla:4.0-dev Nov 13, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 13, 2021
@bembelimen
Copy link
Copy Markdown
Contributor

Thx

@bembelimen bembelimen added this to the Joomla 4.0.5 milestone Nov 13, 2021
@RickR2H RickR2H deleted the categories-layout branch January 25, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants