@mbabker @wilsonge may i have some feedback on this one ?

as no one cares let's close it

let's hope in another chance

I think travis is failing because it needs a migrations sql file too?

where ? and why?
cause no migration needed there are 2 new tables
so my question is migrate what ?

so what i should do... please help me

@mbabker where does travis actually populate the db? Currently missing the place where schema is populated

@alikon migrations folder located https://github.com/joomla/statistics-server/tree/master/etc/migrations create a new file similar to others already there

This line inside the tests. Database is seeded as needed.

(Also, don’t put anything with triggers that use different delimiters inside the migrations, those don’t get parsed out right by PDO so those bits I do have to manually run on the database when ready)

cool. you ok to create the migrations file in that case @alikon ?

Also, just looking at the screenshots, would it not be better to use nested objects instead of complex strings for these groupings?

Instead of:

{
    "data": {
        "cms_php_version": {
            "3.9.16 - 7.4.3": 123,
            "3.9.16 - 7.4.2": 123,
            "3.9.16 - 7.4.1": 123,
            "3.9.16 - 7.4.0": 123
        }
    },
    "total": 492
}

Do this?

{
    "data": {
        "cms_php_version": {
            "3.9.16": {
                "7.4.3": 123,
                "7.4.2": 123,
                "7.4.1": 123,
                "7.4.0": 123
            }
        }
    },
    "total": 492
}

migration file created but travis still complain
https://travis-ci.org/github/joomla/statistics-server/jobs/661838497#L276

If you can run the tests local (which you should be able to, it's basically copy phpunit.xml.dist to phpunit.xml and fill in database creds), add some var dumps to see what migrations are being run. I don't get why the base table doesn't exist (which is the source of the 9 errors) otherwise.

As for the failures:

1) Joomla\StatsServer\Tests\Database\MigrationsTest::testTheMigrationStatusIsCheckedAfterExecutingTheFirstMigration
Failed asserting that 2 is identical to 1.
/home/travis/build/joomla/statistics-server/tests/Database/MigrationsTest.php:65

For this one, the test needs to be updated. I think instead of $this->assertSame(1, $status->missingMigrations);, $this->assertGreaterThanOrEqual(1, $status->missingMigrations); should work here and prevent it needing updated every time a migration is added.

For the view failures, I have no idea how you've changed the builder but it's implying that the JSON is no longer being built correctly (because realistically since the model data is being mocked those shouldn't be failing if you're adding new keys).

1. Do a pull, I fixed a couple of things

2. Merge master, it's a well bit behind and made it impossible for me to run PHPUnit locally

3. How you've added the sources to the StatisticsRepository class won't work, more specifically it has broken getRecentlyUpdatedItems() because there aren't columns for these two dynamic fields

i've modified the getRecentlyUpdatedItems() to manage the 2 new

wow travis is happy now
me quite confused now cause locally i still got 2 error and 5 failure

@alikon can you merge in master here

i'm not allowed to do this from the github UI
so i need your helps if this still matter

It would be better. I think I'm just going to fix forwards here if things break. travis seems to suggest things are ok. so fingers crossed