Skip to content

[RFC] API endpoint for combined DB type & version#41

Closed
alikon wants to merge 4 commits intojoomla:masterfrom
alikon:patch-3
Closed

[RFC] API endpoint for combined DB type & version#41
alikon wants to merge 4 commits intojoomla:masterfrom
alikon:patch-3

Conversation

@alikon
Copy link
Copy Markdown

@alikon alikon commented Sep 7, 2018 •
edited
Loading

Pull Request for Issue #17 .

Summary of Changes

similar to #40

  • create a new table
  • populate the new table with current data
  • implement the insert trigger
  • implement the update trigger
  • expose the new api endpoint

to do

  • mod_joomladata ??

Testing Instructions

apply this patch
from the mysql console
drop the current insert trigger
drop the current update trigger
create the new insert trigger
create the new update trigger
call the new api endopoint http://localhost/jstats/www/?source=db_type_version

this is how the new API endpoint response look like
screenshot from 2018-09-07 19-57-12

@alikon alikon mentioned this pull request Sep 7, 2018
Closed
@mbabker
Copy link
Copy Markdown

mbabker commented Sep 7, 2018

This needs to go through buildResponseData or something similar to ensure the grouping/sanitization step takes place as required (remember the API does not allow access to get the full versions of everything without special permission, result sets are grouped generally on minor versions or the first word of the O/S name for those).

@alikon alikon mentioned this pull request Apr 8, 2019
Merged
@alikon
Copy link
Copy Markdown
Author

alikon commented Apr 8, 2019

reworked on #43

@alikon alikon closed this Apr 8, 2019
@alikon alikon deleted the patch-3 branch April 8, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alikon @mbabker