This repository was archived by the owner on Nov 26, 2017. It is now read-only.
Change JDatabaseDriver, JCacheStorage and JSessionStorage to use isSupported() instead of test().#919
Merged
robschley merged 1 commit intojoomla:stagingfrom Feb 25, 2012
Merged
Conversation
|
Build triggered by changes to the base. The tests completed but there was a problem parsing the report. |
Contributor
|
You've got some issues to fix ;) |
…pported() instead of test().
|
Build triggered by changes to the head. Unit testing complete. There were 0 failures and 0 errors from 2173 tests and 11532 assertions. |
robschley
added a commit
that referenced
this pull request
Feb 25, 2012
Change JDatabaseDriver, JCacheStorage and JSessionStorage to use isSupported() instead of test().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes this the same across all packaged and isSupported() is just much more descriptive than test(). I also changed all the tests to use dynamic access to static methods instead of call_user_func_array() since we're know in PHP 5.3 land.