This repository was archived by the owner on Nov 26, 2017. It is now read-only.
Add minimum supported version information to database drivers#830
Merged
chdemko merged 5 commits intojoomla:stagingfrom Feb 7, 2012
mbabker:JDatabase_minimum
Merged
Add minimum supported version information to database drivers#830chdemko merged 5 commits intojoomla:stagingfrom mbabker:JDatabase_minimum
chdemko merged 5 commits intojoomla:stagingfrom
mbabker:JDatabase_minimum
Conversation
|
Unit testing complete. There were 0 failures and 0 errors from 1993 tests and 11153 assertions. |
Contributor
There was a problem hiding this comment.
You can define this property static
Contributor
|
We could add a method to JDatabase And define in JDatabase |
Contributor
Author
|
getVersion is already abstract in JDatabase, working the other changes right now. |
Contributor
Author
|
Changes pushed up. |
|
Build triggered by changes to the head. Unit testing complete. There were 0 failures and 0 errors from 1994 tests and 11154 assertions. |
chdemko
added a commit
that referenced
this pull request
Feb 7, 2012
Add minimum supported version information to database drivers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the minimum supported version information to the database drivers and a method to retrieve that string. The values currently used are MySQL 5.0.4 (the CMS minimum version at present) and SQL Server 2008 R2 (internal version 10.50.1600.1, per a discussion I had with Sudhi yesterday). I've also modified the getVersion method for SQL Server to just return the version string instead of the full array the sqlsrv_server_info method returns.