This repository was archived by the owner on Nov 26, 2017. It is now read-only.
Fixing warnings triggered by cURL when no response is received.#1438
Merged
LouisLandry merged 1 commit intojoomla:stagingfrom Aug 6, 2012
pasamio:curl_warnings
Merged
Fixing warnings triggered by cURL when no response is received.#1438LouisLandry merged 1 commit intojoomla:stagingfrom pasamio:curl_warnings
LouisLandry merged 1 commit intojoomla:stagingfrom
pasamio:curl_warnings
Conversation
LouisLandry
added a commit
that referenced
this pull request
Aug 6, 2012
Fixing warnings triggered by cURL when no response is received.
Contributor
|
Please take a look at my PR #1022. |
This was referenced Aug 7, 2012
Contributor
|
Actually there's a difference between getting empty content and what you get from a bad url where in fact you are not going to get a normal repsonse code since there is no server. I haven't tested it yet but I bet it isn't pretty if the $uri doesn't exist, it probably needs an exception and then JTransportCurl needs to handle that. And yes the error issue is a problem because php is going to send a notice before any exception gets thrown. Needs to catch that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves a situation where when no response from a server is received a PHP warning is thrown by the cURL transport. Instead the code triggering the warning is mitigated and additionally a check to see if there was any response data is added to validate a response was actually received or throw an exception.