Skip to content
This repository was archived by the owner on Nov 26, 2017. It is now read-only.

Updated database session code to avoid duplication of session id#1209

Merged
LouisLandry merged 5 commits intostagingfrom
unknown repository
Jun 19, 2012
Merged

Updated database session code to avoid duplication of session id#1209
LouisLandry merged 5 commits intostagingfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented May 15, 2012

See #454 for original request. Repository reorg removed the old fix, so here is a new, updated one.

@piotr-cz
Copy link
Copy Markdown
Contributor

piotr-cz commented May 16, 2012

@garyamort
Please correct the checkstyle errors: tabs for indent and comments starting with capital, see http://developer.joomla.org/pulls/pulls/1209.html for details

We really need this fixed :)
Without this Joomla crashes on multiple concurrent requests (ajax/ thumbnails for image galleries etc).

I've added this fix as a separate Storage storage handler 5 months ago to my app and didn't notice any new issues.

@elinw
Copy link
Copy Markdown
Contributor

elinw commented May 17, 2012

http://developer.joomla.org/pulls/pulls/1209.html

libraries/joomla/session/storage/database.php:116
Please consider the /* */ style for comments that span over multiple lines.
libraries/joomla/session/storage/database.php:117
Whitespace found at end of line
libraries/joomla/session/storage/database.php:119
Tabs must be used to indent lines; spaces are not allowed

elinw
elinw reviewed May 17, 2012
View reviewed changes
libraries/joomla/session/storage/database.php Outdated
Copy link
Copy Markdown
Contributor

@elinw elinw May 17, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could make these two lines and make Jenkins happy.

@realityking
Copy link
Copy Markdown
Contributor

realityking commented Jun 2, 2012

Still 3 code style issues: http://developer.joomla.org/pulls/pulls/1209.html

@LouisLandry
Copy link
Copy Markdown
Contributor

LouisLandry commented Jun 19, 2012

Thanks Gary!

LouisLandry added a commit that referenced this pull request Jun 19, 2012
@LouisLandry
Merge pull request #1209 from gmJoomla/SessionUpdateFix
a46a069 
Updated database session code to avoid duplication of session id
@LouisLandry LouisLandry merged commit a46a069 into joomla:staging Jun 19, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Issue fixed

Projects

None yet

Milestone

12.2

Development

Successfully merging this pull request may close these issues.

5 participants

@piotr-cz @elinw @realityking @LouisLandry @gamort