Create Categories on-the-fly on Contact edit form by pe7er · Pull Request #8634 · joomla/joomla-cms

pe7er · 2015-12-09T15:47:33Z

This PR adds a new functionality to the Contact edit form that makes it possible to create & assign a new Category on the fly. See also PR #8623.

Testing Instructions

This PR uses some code in com_categories from PR #8623.
Please install PR #8623 before testing this PR.

Before the PR

Go to Components > Contacts > [New]
Create a new Contact (Title) and select an existing Category.

After the PR

Go to Components > Contacts > [New]
Create a new Contact (Title) and click on the Category dropdown.

The Category dropdown now has an option to add a new Category name.

Don't forget to click on to select your newly created Category.
When you save the Contact, the new category will be created.

After save the new Category will be in the category list (a hyphen is added in front of it).

kleinhelmi · 2015-12-14T10:45:58Z

I have tested this item ✅ successfully on c3997c0

tested on Apache/2.4.10 (Win32) OpenSSL/1.0.1i PHP/5.5.15

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8634.}

anibalsanchez · 2015-12-19T19:13:25Z

I have tested this item 🔴 unsuccessfully on c3997c0

I tested in the latest stating, but it does now allow to click on "Add new Category 'test'"

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8634.}

brianteeman · 2016-03-10T15:25:21Z

I have tested this item 🔴 unsuccessfully on c3997c0

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8634.}

brianteeman · 2016-03-10T17:17:04Z

@pe7er my test above was with 3.5rc - I just tested one of the other already RTC pr for this add category feature and that didnt work either so maybe its an issue since 3.5 that it doesnt work

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8634.}

MATsxm · 2016-03-10T19:03:23Z

I have tested this item 🔴 unsuccessfully on c3997c0

unsuccessful on 3.5rc

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8634.}

pe7er · 2016-03-11T09:50:37Z

Thank you all for testing!

I've to get back to the drawing board to check why it fails,
or I might redo this PR on J3.5 Stable when it has been released.
Thanks!

brianteeman · 2016-03-11T10:03:09Z

@pe7er I will remove the RTC status on all of them for now with a note
saying you are reviewing them

On 11 March 2016 at 09:50, Peter Martin notifications@github.com wrote:

Thank you all for testing!

I've to get back to the drawing board to check why it fails,
or I might redo this PR on J3.5 Stable when it has been released.
Thanks!

—
Reply to this email directly or view it on GitHub
#8634 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

brianteeman · 2016-03-11T10:06:00Z

Ah - I just spotted you had to have #8623 applied first - I completely
missed that- let me retest

On 11 March 2016 at 10:02, Brian Teeman brian@teeman.net wrote:

@pe7er I will remove the RTC status on all of them for now with a note
saying you are reviewing them

On 11 March 2016 at 09:50, Peter Martin notifications@github.com wrote:

Thank you all for testing!

I've to get back to the drawing board to check why it fails,
or I might redo this PR on J3.5 Stable when it has been released.
Thanks!

—
Reply to this email directly or view it on GitHub
#8634 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

brianteeman · 2016-03-11T10:30:06Z

I have tested this item ✅ successfully on c3997c0

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8634.}

brianteeman · 2016-03-11T10:31:22Z

Yeah - it was me being an idiot and not applying the other PR first

@anibalsanchez @MATsxm can you please retest and make sure that you apply #8623 first

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8634.}

MATsxm · 2016-03-11T12:25:53Z

I have tested this item 🔴 unsuccessfully on c3997c0

I had already apply #8623 yesterday and was unsuccessful.

Try it again today (3.5rc) applying #8623 then applying #8634 and no way for me to create "Some New Category" :(

Sorry but still unsuccessful to me

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8634.}

mikeveeckmans · 2016-03-30T22:52:41Z

I have tested this item ✅ successfully on c3997c0

TEST OK

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8634.}

brianteeman · 2016-03-31T07:26:13Z

I tested again and have no issues setting RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8634.}

Fixes #8634

wilsonge · 2016-04-09T14:28:53Z

Merged with 745990f - thanks again Peter!

Create Categories on-the-fly on Contact edit form

8b37390

joomla-cms-bot added the PR-staging label Dec 9, 2015

changed require_once to JLoader::register

c3997c0

Kubik-Rubik added the Feature label Dec 10, 2015

Kubik-Rubik modified the milestones: Joomla! 3.5.0, Joomla! 3.6.0 Dec 10, 2015

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 31, 2016

wilsonge added a commit that referenced this pull request Apr 9, 2016

Merge branch 'categories' into 3.6.x

745990f

Fixes #8634

wilsonge closed this Apr 9, 2016

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 9, 2016

wilsonge added a commit that referenced this pull request May 20, 2016

Merge branch 'contact_merge' into staging. Fixes #8634

79231fd

This was referenced Nov 10, 2016

Permissions select fields in 3.7.0 diferent from 3.6.4 #12843

Closed

Remove Searchbox from all fields except Category #12855

Merged

pe7er deleted the contact_freecategory branch September 25, 2018 13:45

Uh oh!

Conversation

pe7er commented Dec 9, 2015

Testing Instructions

Before the PR

After the PR

Uh oh!

kleinhelmi commented Dec 14, 2015

Uh oh!

anibalsanchez commented Dec 19, 2015

Uh oh!

brianteeman commented Mar 10, 2016

Uh oh!

brianteeman commented Mar 10, 2016

Uh oh!

MATsxm commented Mar 10, 2016

Uh oh!

pe7er commented Mar 11, 2016

Uh oh!

brianteeman commented Mar 11, 2016

Uh oh!

brianteeman commented Mar 11, 2016

Uh oh!

brianteeman commented Mar 11, 2016

Uh oh!

brianteeman commented Mar 11, 2016

Uh oh!

MATsxm commented Mar 11, 2016

Uh oh!

mikeveeckmans commented Mar 30, 2016

Uh oh!

brianteeman commented Mar 31, 2016

Uh oh!

wilsonge commented Apr 9, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants