Utilize safe string methods in JCrypt#8354
Merged
wilsonge merged 1 commit intojoomla:stagingfrom Nov 9, 2015
mbabker:safeStrMethods
Merged
Utilize safe string methods in JCrypt#8354wilsonge merged 1 commit intojoomla:stagingfrom mbabker:safeStrMethods
wilsonge merged 1 commit intojoomla:stagingfrom
mbabker:safeStrMethods
Conversation
Contributor
|
👍 There are other instances that need to be updated but that can come later. |
wilsonge
added a commit
that referenced
this pull request
Nov 9, 2015
Utilize safe string methods in JCrypt
Contributor
|
Merged on review |
Contributor
|
Code reviewed 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the safe string helper methods from
\ParagonIE\Halite\Util(essentially as a fork since that library requires PHP 5.6) and utilizes thesafeStrlen()method in ourJCrypt::timingSafeCompare()method to address the issue raised in #8330.