[3.5.0 Beta] Fix permissons editing with the PDO Driver#8322
Merged
wilsonge merged 3 commits intojoomla:stagingfrom Nov 9, 2015
zero-24:fix_com_config_pdo
Merged
[3.5.0 Beta] Fix permissons editing with the PDO Driver#8322wilsonge merged 3 commits intojoomla:stagingfrom zero-24:fix_com_config_pdo
wilsonge merged 3 commits intojoomla:stagingfrom
zero-24:fix_com_config_pdo
Conversation
Member
|
I can confirm, that this pull fixes part of #8321 issue 😉 |
Contributor
There was a problem hiding this comment.
allways = always (one l 😄 )
Contributor
|
I've tested this and it works - but I'd much prefer the solution that I've commented in the code - which does the same thing in far less code :) |
Member
|
I have tested this item ✅ successfully on 8f311e9 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8322. |
|
This PR has received new commits. CC: @Fedik This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8322. |
Contributor
Author
|
Fixed @wilsonge |
Contributor
|
I have tested this item ✅ successfully on 93ff193 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8322. |
Member
|
I have tested this item ✅ successfully on 93ff193 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8322. |
Contributor
Author
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8322. |
wilsonge
added a commit
that referenced
this pull request
Nov 9, 2015
[3.5.0 Beta] Fix permissons editing with the PDO Driver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed
Not allways we get a boolean if a SQL is true. e.g. on PDO we get a PDO object.
How to test
Fixes #8321 Thnaks @Fedik