Adds an onAfterRenderModule trigger · Pull Request #8296 · joomla/joomla-cms

ghost · 2015-11-06T11:38:01Z

This PR adds an extra event trigger to the module rendering process.
This way plugins can manipulate the rendered output of modules separately.

To test, create a system plugin foobar with this:

class PlgSystemFooBar extends JPlugin
{
    public function onAfterRoute()
    {
        JFactory::getApplication()->registerEvent('onAfterRenderModule', array($this, 'onAfterRenderModule'));
    }

    public function onAfterRenderModule(&$module)
    {
        if (is_null($module))
        {
            return;
        }

        $module->content = '<p style="color:red">Module content replaced</p>';
    }
}

Or add the registerEvent and onAfterRenderModule code to an existing plugin.

This PR adds an extra event trigger to the module rendering process. This way plugins can manipulate the rendered output of modules separately.

Kubik-Rubik · 2015-11-06T12:08:38Z

@nonumber Makes sense to have such a trigger, thank you! Please remove the whitespaces in line 260.

richard67 · 2015-11-06T12:22:09Z

@nonumber Just seen that there is PR #3105 for the same purpose (but with a different solution) with milestone Joomla! 3.6.0. Is this one here now a duplicate, and the old one should be closed if this one is accepted?

ghost · 2015-11-06T12:25:11Z

That PR is for the complete module position. Modules (plural) as opposed to module.
So not a duplicate. Different use.

richard67 · 2015-11-06T12:26:03Z

Ah, ok, I see. Thanks for the clarification.

brianteeman · 2015-12-18T14:24:06Z

Are these three issues related #8693 #8296 #3105

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8296.}

ghost · 2015-12-18T14:29:39Z

#8296 is the same as #8693.

#3105 is something different:

That PR is for the complete module position. Modules (plural) as opposed to module.
So not a duplicate. Different use.

kanich · 2015-12-18T16:12:13Z

Exactly as @nonumber expressed above - #3105 is dealing with class JDocumentRendererModules in libraries/joomla/document/html/renderer/modules.php file. All other PRs are different.

waader · 2016-01-06T12:21:48Z

I have tested this item ✅ successfully on abfc4ee

Thanks nonumber!

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8296.}

ced1870 · 2016-01-07T17:55:14Z

I have tested this item ✅ successfully on abfc4ee

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8296.}

ghost · 2016-01-26T23:59:12Z

Any chance this can get merged before it gets out of sync?

ced1870 · 2016-01-27T07:50:06Z

+1 with Peter. This is a needed improvement

brianteeman · 2016-01-27T10:56:47Z

(someone has set this to 3.6 milestone)

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8296.}

ced1870 · 2016-01-27T11:41:22Z

thank you Brian.
Sorry for my ignorance about all this process. Does this mean that it will integrated, or is it still waiting for something like says the "pr-staging" label ?

brianteeman · 2016-01-27T11:47:34Z

What it means is that someone has decided that this can only be merged in Joomla 3.6

ghost · 2016-01-27T11:49:52Z

So should I change this so it is a PR to the 3.6.x branch?
Or does this just stay open till someone feels like merging it to that branch?

brianteeman · 2016-01-27T11:53:53Z

As far as I know its the latter

On 27 January 2016 at 11:50, Peter van Westen notifications@github.com
wrote:

So should I change this so it is a PR to the 3.6.x branch?
Or does this just stay open till someone feels like merging it to that
branch?

—
Reply to this email directly or view it on GitHub
#8296 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Adds an onAfterRenderModule trigger

ghost · 2016-01-28T20:26:43Z

Thanks :)

Kubik-Rubik · 2016-01-29T09:45:03Z

@wilsonge Since it is merged now for Joomla! 3.5, we should not forget to update the documentation for core triggers! @MATsxm

MATsxm · 2016-01-29T12:27:22Z

👍
As a non dev, I will let you got for it but let me know if any help is needed.
https://docs.joomla.org/Plugin/Events
Thanks all

Adds an onAfterRenderModule trigger

3fab6cd

This PR adds an extra event trigger to the module rendering process. This way plugins can manipulate the rendered output of modules separately.

joomla-cms-bot added the PR-staging label Nov 6, 2015

Fixed whitespace

d133aa8

wilsonge modified the milestone: Joomla! 3.6.0 Nov 6, 2015

wilsonge added the Feature label Nov 6, 2015

zero-24 added this to the Joomla! 3.6.0 milestone Nov 7, 2015

brianteeman mentioned this pull request Dec 18, 2015

Add Event onAfterRenderModule #8693

Closed

brianteeman mentioned this pull request Dec 18, 2015

Proposed onAfterRenderModules event in modules rendering #3105

Closed

Added Attribs to trigger

abfc4ee

wilsonge added a commit that referenced this pull request Jan 28, 2016

Merge pull request #8296 from nonumber/patch-1

410ce3b

Adds an onAfterRenderModule trigger

wilsonge merged commit 410ce3b into joomla:staging Jan 28, 2016

wilsonge modified the milestones: Joomla! 3.5.0, Joomla! 3.6.0 Jan 28, 2016

ghost deleted the patch-1 branch January 28, 2016 20:26

kanich mentioned this pull request Sep 4, 2016

Proposed onAfterRenderModules event in modules rendering #10113

Merged

Uh oh!

Conversation

ghost commented Nov 6, 2015

Uh oh!

Kubik-Rubik commented Nov 6, 2015

Uh oh!

richard67 commented Nov 6, 2015

Uh oh!

ghost commented Nov 6, 2015

Uh oh!

richard67 commented Nov 6, 2015

Uh oh!

brianteeman commented Dec 18, 2015

Uh oh!

ghost commented Dec 18, 2015

Uh oh!

kanich commented Dec 18, 2015

Uh oh!

waader commented Jan 6, 2016

Uh oh!

ced1870 commented Jan 7, 2016

Uh oh!

ghost commented Jan 26, 2016

Uh oh!

ced1870 commented Jan 27, 2016

Uh oh!

brianteeman commented Jan 27, 2016

Uh oh!

ced1870 commented Jan 27, 2016

Uh oh!

brianteeman commented Jan 27, 2016

Uh oh!

ghost commented Jan 27, 2016

Uh oh!

brianteeman commented Jan 27, 2016

Uh oh!

ghost commented Jan 28, 2016

Uh oh!

Kubik-Rubik commented Jan 29, 2016

Uh oh!

MATsxm commented Jan 29, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants