Remove automatic HTML comments for layouts until we get it working properly#8251
Merged
wilsonge merged 1 commit intojoomla:stagingfrom Nov 2, 2015
Merged
Remove automatic HTML comments for layouts until we get it working properly#8251wilsonge merged 1 commit intojoomla:stagingfrom
wilsonge merged 1 commit intojoomla:stagingfrom
Conversation
wilsonge
added a commit
that referenced
this pull request
Nov 2, 2015
Remove automatic HTML comments for layouts until we get it working properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts a new feature added in #8234
Some layout output is used directly in JS functions and this feature breaks them. Example:
https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/modal/main.php#L68-L73
To see the error try to edit any menu item with debug enabled from joomla configuration. It causes a JS error that breaks edit page. After applying this PR everything works again.