PostgreSQL - tag popular module error#8242
Merged
wilsonge merged 2 commits intojoomla:stagingfrom Nov 5, 2015
alikon:sqlrand
Merged
PostgreSQL - tag popular module error#8242wilsonge merged 2 commits intojoomla:stagingfrom alikon:sqlrand
wilsonge merged 2 commits intojoomla:stagingfrom
alikon:sqlrand
Conversation
Contributor
|
I have tested this item ✅ successfully on 103abed This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8242. |
Contributor
|
You can't change the parameter value like this. It will break for people who have already saved the existing parameter |
|
This PR has received new commits. CC: @zero-24 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8242. |
modules/mod_tags_popular/helper.php
Outdated
Contributor
There was a problem hiding this comment.
if ($order_value == 'random' or $order_value == 'rand()') for B/C as @wilsonge posted
Contributor
Author
|
param unchanged now |
This was referenced Nov 2, 2015
Contributor
|
I have tested this item ✅ successfully on 0c875a5 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8242. |
wilsonge
added a commit
that referenced
this pull request
Nov 5, 2015
PostgreSQL - tag popular module error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce the issue
Set the tag popular module parameter Order to random
Click on Popular Tags item from the fronted left menu All Modules
Actual result
you got a sql error message
How to tests
Apply the pacth
Addictional Comments
similar to #8238,#8240
was used
RAND()instead of the api$query->Rand()