Skip to content

Display max input vars (redo #7453)#8239

Merged
roland-d merged 3 commits intojoomla:stagingfrom
zero-24:maxInputVars
Nov 2, 2015
Merged

Display max input vars (redo #7453)#8239
roland-d merged 3 commits intojoomla:stagingfrom
zero-24:maxInputVars

Conversation

@zero-24
Copy link
Copy Markdown
Contributor

@zero-24 zero-24 commented Nov 2, 2015

Quote form @brianteeman see: #7453 (comment)

Since php 5.3.9 there is a php setting for the number of max_inut_vars with a default value of 1000

This pr just adds a test to display the value in com_admin&view=sysinfo

Knowing the value is quite important now especially on sites with a large number of menus, usergroups or modules as if the value for max_input_vars is not big enough then saving will fail silently or will be truncated.

What is this

This PR just displays the setting "Max Imput Vars" to the Backend PHP settings.

How to test

  • login to the backend
  • Go to the Systeminformation (BE -> System -> Systeminformation)
  • There is a Tab "PHP Settings"
  • Confirm that bevor the patch there is no entry for "max input vars"
  • apply the patch
  • confirm that we now show the may input vars

Original Idea

Kudos goes to @brianteeman see: http://issues.joomla.org/tracker/joomla-cms/7453

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Nov 2, 2015
@waader
Copy link
Copy Markdown
Contributor

waader commented Nov 2, 2015

I have tested this item ✅ successfully on 29bae22

Thanks zero-24!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8239.

@mironsavan
Copy link
Copy Markdown

mironsavan commented Nov 2, 2015

I have tested this item ✅ successfully on 29bae22

I have tested this and works as expected.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8239.

@zero-24 zero-24 added this to the Joomla! 3.5.0 milestone Nov 2, 2015
@zero-24
Copy link
Copy Markdown
Contributor Author

zero-24 commented Nov 2, 2015

RTC. Thanks for testing and the idea @brianteeman 👍

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8239.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 2, 2015
roland-d added a commit that referenced this pull request Nov 2, 2015
@roland-d
Merge pull request #8239 from zero-24/maxInputVars
e2e3a05 
Display max input vars (redo #7453)
@roland-d roland-d merged commit e2e3a05 into joomla:staging Nov 2, 2015
@zero-24 zero-24 deleted the maxInputVars branch November 2, 2015 20:21
@wilsonge wilsonge removed the RTC This Pull Request is Ready To Commit label Jan 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Language Change This is for Translators

Projects

None yet

Milestone

Joomla! 3.5.0

Development

Successfully merging this pull request may close these issues.

6 participants

@zero-24 @waader @mironsavan @roland-d @wilsonge @joomla-cms-bot