SQL: Wrong title for Contacts submenu#8212
Conversation
|
If you're only changing the one field an |
|
@mbabker |
following joomla#8212 (comment)
following advice+glip
the mssql
the mysql
the postgresql
|
Thanks @alikon :) |
|
We need here one more test to RTC. |
|
@test |
|
I have tested this item ✅ successfully on f3795d0 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8212. |
|
RTC as we have 2 good tests This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8212. |
SQL: Wrong title for Contacts submenu
|
Just updated a Joomla installation (in a test environment) from 3.4.8 to 3.5 (using MySQL). The title of menu item with ID 8 was changed from "Geschiedenis" to "com_contact_contacts" as stated in this PR. I think other people with (somehow) non-default menu item IDs may/will have the same problem. My proposal is to only change the title for menu items which matches the follow criteria: For MySQL the following query does the job from phpMyAdmin: If you agree I wil be happy to change the queries and submit another PR. I also can help testing for MySQL because I did not upgrade my production installation yet. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8212. |
|
@ratenfanger you are commenting on a pull request that was merged five months ago |
|
@brianteeman sorry I thought this was the correct place to discuss my findings. Should I create a new issue and mention this PR? |
|
Yes please
|
This PR to solve #8200
The submenu title is incorrect in the db, therefore it does not use the right string
COM_CONTACT_CONTACTSPatch and make new installation or run the sql request (change #_ to your db prefix) on an existing site:
In en-GB, the values of COM_CONTACT and COM_CONTACT_CONTACTS are the same (Contacts) in the en-GB.com_contact.sys.ini language file.
Therefore to test in en-GB, just modify the value of COM_CONTACT_CONTACTS
Result in French:

NOTE: I have just updated sql in /administrator/components/com_admin/sql/updates/mysql/3.5.0-2015-10-30.sql
I have not touched at postgres and sqlazure there. To who knows how to, please propose a PR for that.