Use bootstrap modal for preview on com_media#7819
Closed
dgrammatiko wants to merge 6 commits intojoomla:stagingfrom
dgrammatiko:____bootstrap.Com.Media.Modal
Closed
Use bootstrap modal for preview on com_media#7819dgrammatiko wants to merge 6 commits intojoomla:stagingfrom dgrammatiko:____bootstrap.Com.Media.Modal
dgrammatiko wants to merge 6 commits intojoomla:stagingfrom
dgrammatiko:____bootstrap.Com.Media.Modal
Conversation
Contributor
Author
There was a problem hiding this comment.
@wilsonge George this muted part together with the other lines above should be enough for the modal to open in the parent window. Still haven’t found a way to update the video source, need to walk through the API/code of the player
Contributor
There was a problem hiding this comment.
just do something like
jQuery(document).ready(function($){
window.parent.document.updateUploader();
$('.img-preview, .preview').each(function(index, value) {
$(this).on('click', function(e) {
window.parent.jQuery('#videoPreview.modal video.mejs-player')[0].player.setSrc($(this).attr('href'));
window.parent.jQuery('#imagePreview').modal('show');
return false;
});
});
});
Contributor
|
Looks OK. |
Contributor
There was a problem hiding this comment.
I guess this string needs to go as well
Contributor
Contributor
|
Tested successfully This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7819. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7819. |
Member
This was referenced Oct 3, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Eliminate mootools usage and use bootstrap modal for previewing the images.
Also scripts and stylesheets were called all over the place, now they follow Joomla's best practices
B/C
As long as the templates use bootstrap (admin area) there shouldn’t be any problems. Any overrides NEED to be updated!
Performance
Should be a bit quicker without mootools eating some of the rendering time, downloading, http requests etc.
Testing
Apply the patch and see if everything still works correctly.
Report any problems or any ideas for improvement
Preview