Skip to content

Update tinyMCE to version 4.2.6#7667

Merged
rdeutz merged 5 commits intojoomla:stagingfrom
dgrammatiko:tinyMCE_4.2.3
Oct 19, 2015
Merged

Update tinyMCE to version 4.2.6#7667
rdeutz merged 5 commits intojoomla:stagingfrom
dgrammatiko:tinyMCE_4.2.3

Conversation

@dgrammatiko
Copy link
Copy Markdown
Contributor

@dgrammatiko dgrammatiko commented Aug 9, 2015

Sync with the latest release

This is an update from 4.1.6 to the latest version: 4.2.6
There are a lot of bug fixes and also a new flat theme

Here is a preview:
screen shot 2015-10-05 at 09 11 45

@infograf768 This is a bug fix release so there shouldn’t be any new language strings here (that was already done in 4.2)

Testing

Please don’t use patch tester for this one. You need to use Git here to get the commit (or manually overwrite the files)

An even easier method: download https://github.com/dgt41/joomla-cms/archive/tinyMCE_4.2.3.zip and install as usual

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Aug 9, 2015

@DGT41
Don't we still need the tiny lang updates before next release as we are still in core at version 4.1.7? This has to be organised by Mig.

@dgrammatiko
Copy link
Copy Markdown
Contributor Author

dgrammatiko commented Aug 9, 2015

@infograf768 Oh sure, the stings introduced in 4.2 needs to be translated

@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Sep 2, 2015

@infograf768 do we have any information from Mig about how this is going?

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Sep 2, 2015

@wilsonge
You folks have to contact him to organise this.
Some of the new files should be posted in the Translation Teams Forum and then merged.
What is not so simple is that some must be provided by TTs (as the ones available in Tiny specific page are not good enough) and others have to be used as they are (after some name modifications to fit our needs) from the Tiny site.
As far as I know, nothing was done yet.

If this is the only aspect which prevents you from merging this PR, no worry.
Updated translation files can be gathered for next release.
Someone though should test this PR

@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Sep 2, 2015

@DGT41 Can we upgrade this to tiny 4.2.5 please. I'm talking with mig at the moment for the translation aspect

@dgrammatiko
Copy link
Copy Markdown
Contributor Author

dgrammatiko commented Sep 2, 2015

@wilsonge 4.2.5 done!

@dgrammatiko
Copy link
Copy Markdown
Contributor Author

dgrammatiko commented Sep 2, 2015

@wilsonge @infograf768 about the translation: the new strings are for the image tools which Joomla is not using right now, and I will say neither any of the users should use it at the time, as they will end up saving the images in their database. To cut it short, translation of those strings is welcome but not mandatory at the moment

@dgrammatiko dgrammatiko changed the title Update tinyMCE to version 4.2.3 Update tinyMCE to version 4.2.5 Sep 4, 2015
@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Sep 5, 2015

translation of those strings is welcome but not mandatory at the moment

Indeed.

@zero-24 zero-24 added this to the Joomla! 3.4.5 milestone Sep 5, 2015
@dgrammatiko dgrammatiko mentioned this pull request Sep 21, 2015
Merged
@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Sep 22, 2015

The Tiny version in the xml needs updating.

Other than that, it looks like working BUT something important has changed for the language files (will inform TTs and Thomas):

The first line of each xx.js or xx-XX.js has to contain the same tag as the name of the file (as they exist already in core).

Example for French fr.js
It has as first line
tinymce.addI18n('fr_FR',{

it should be
tinymce.addI18n('fr',{

For Brazilian pt-BR.js
it has tinymce.addI18n('pt_BR',{
it should now be
tinymce.addI18n('pt-BR',{

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Sep 23, 2015

Ok for me. One more tester.

@dgrammatiko dgrammatiko changed the title Update tinyMCE to version 4.2.5 Update tinyMCE to version 4.2.6 Oct 5, 2015
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Oct 5, 2015

It looks like all the 3.x compatibility plugins have been removed :/

@rdeutz rdeutz mentioned this pull request Oct 5, 2015
Merged
dgrammatiko
dgrammatiko reviewed Oct 5, 2015
View reviewed changes
media/editors/tinymce/plugins/compat3x/tiny_mce_popup.js Outdated
Copy link
Copy Markdown
Contributor Author

@dgrammatiko dgrammatiko Oct 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line explains why there is a css and an omg folder in the compat3x folder. Also the new skin dropped most of the icons...

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Oct 6, 2015

Shall we not delete all compat3x folder and add these files in com_admin/script.php as anyway they are never used in J3.x ?

@dgrammatiko
Copy link
Copy Markdown
Contributor Author

dgrammatiko commented Oct 6, 2015

This will simplify the update process for tinyMCE, but it’s PLT’s call

@dgrammatiko
Remove compat3x folder
6b66a1a 
Update script.php
@joomla-cms-bot
Copy link
Copy Markdown

joomla-cms-bot commented Oct 6, 2015

This PR has received new commits.

CC: @infograf768

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7667.

@slibbe
Copy link
Copy Markdown

slibbe commented Oct 18, 2015

I have tested this item ✅ successfully on 6b66a1a

I have tested this and it seems to work ok. However, I don't know what the bugs with the older version were or what other attention points there may be.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7667.

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Oct 19, 2015

I have tested this item ✅ successfully on 6b66a1a

OK here

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7667.

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Oct 19, 2015

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7667.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 19, 2015
@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Oct 19, 2015

Please inform TTs when this is merged as quite a few tiny langs have to be updated

@Bakual
Copy link
Copy Markdown
Contributor

Bakual commented Oct 19, 2015

@infograf768 I've updated the language files with 458b617 using the packs provided by the translators and also fixed the tags you mentioned in the thread. Can you have a look over it if it's correct?

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Oct 19, 2015

Already on it ;)

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Oct 19, 2015

Looks OK as far as I could see.

rdeutz added a commit that referenced this pull request Oct 19, 2015
@rdeutz
Merge pull request #7667 from dgt41/tinyMCE_4.2.3
a07c1f5 
Update tinyMCE to version 4.2.6
@rdeutz rdeutz merged commit a07c1f5 into joomla:staging Oct 19, 2015
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 19, 2015
@dgrammatiko dgrammatiko deleted the tinyMCE_4.2.3 branch October 19, 2015 08:41
@zero-24 zero-24 modified the milestones: Joomla! 3.4.6, Joomla! 3.5.0 Oct 28, 2015
@jsubri jsubri mentioned this pull request Aug 23, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla! 3.5.0

Development

Successfully merging this pull request may close these issues.

8 participants

@dgrammatiko @infograf768 @wilsonge @joomla-cms-bot @slibbe @zero-24 @Bakual @rdeutz