Skip to content

[3.5] [imp] Add the ability to use a custom CSS file with beez3 & make the other similiar checks consistend see #4211#7621

Merged
roland-d merged 3 commits intojoomla:3.5-devfrom
zero-24:usercss_beez
Oct 24, 2015
Merged

[3.5] [imp] Add the ability to use a custom CSS file with beez3 & make the other similiar checks consistend see #4211#7621
roland-d merged 3 commits intojoomla:3.5-devfrom
zero-24:usercss_beez

Conversation

@zero-24
Copy link
Copy Markdown
Contributor

@zero-24 zero-24 commented Aug 3, 2015

This backports the user.css that we have in protostar back to beez3. For the backed we can use a custom.css file.

How to test

  • set beez3 as default template
  • access the frontend
  • see all is good.
  • apply the patch
  • add a user.css with custom styling to this folder /templates/bezz3/css/user.css
  • reload the page
  • see that the file gets loaded.

Other changes

Make the checks consistent and use if (file_exists($file) && filesize($file) > 0) and $doc->addStyleSheetVersion($file);

@zero-24 zero-24 added the Feature label Aug 3, 2015
@zero-24 zero-24 added this to the Joomla! 3.5.0 milestone Aug 3, 2015
@brianteeman
Copy link
Copy Markdown
Contributor

The title says Beez but there are changes in all 4 templates?

@zero-24
Copy link
Copy Markdown
Contributor Author

zero-24 commented Aug 3, 2015

yes as the "new feature" is only in beez and the others are just changed to be consistend. But to avoid confusing i will fix the title

@zero-24 zero-24 changed the title [3.5] [imp] Add the ability to use a custom CSS file with beez3 see #4211 [3.5] [imp] Add the ability to use a custom CSS file with beez3 & make the other similiar checks consistend see #4211 Aug 3, 2015
@SiteOp
Copy link
Copy Markdown

SiteOp commented Sep 12, 2015

Test Beez/Protostar. It works.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7621.

@crommie
Copy link
Copy Markdown

crommie commented Oct 10, 2015

I have tested this item ✅ successfully on bb1f130

Tested. Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7621.

3 similar comments
@crommie
Copy link
Copy Markdown

crommie commented Oct 10, 2015

I have tested this item ✅ successfully on bb1f130

Tested. Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7621.

@crommie
Copy link
Copy Markdown

crommie commented Oct 10, 2015

I have tested this item ✅ successfully on bb1f130

Tested. Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7621.

@crommie
Copy link
Copy Markdown

crommie commented Oct 10, 2015

I have tested this item ✅ successfully on bb1f130

Tested. Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7621.

@snarf007
Copy link
Copy Markdown

I have not tested this item.

Applied patch and created the user.css file via the template manager.
Added the following code in the css file:
body {
background: pink;
}

Result a pink backgound in the frontend.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7621.

@snarf007
Copy link
Copy Markdown

I have tested this item ✅ successfully on bb1f130

Applied patch and created the user.css file via the template manager.
Added the following code in the css file:
body {
background: pink;
}

Result a pink backgound in the frontend.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7621.

@zero-24
Copy link
Copy Markdown
Contributor Author

zero-24 commented Oct 10, 2015

RTC. Thanks for testing!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7621.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 10, 2015
roland-d added a commit that referenced this pull request Oct 24, 2015
[3.5] [imp] Add the ability to use a custom CSS file with beez3 & make the other similiar checks consistend see #4211
@roland-d roland-d merged commit 1268751 into joomla:3.5-dev Oct 24, 2015
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 24, 2015
@roland-d
Copy link
Copy Markdown
Contributor

Thanks all, change has been merged.

@zero-24 zero-24 deleted the usercss_beez branch October 24, 2015 11:59
@zero-24
Copy link
Copy Markdown
Contributor Author

zero-24 commented Oct 24, 2015

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants