Skip to content

Visual update for isis#7610

Closed
dgrammatiko wants to merge 7 commits intojoomla:stagingfrom
dgrammatiko:____ISIS_UI
Closed

Visual update for isis#7610
dgrammatiko wants to merge 7 commits intojoomla:stagingfrom
dgrammatiko:____ISIS_UI

Conversation

@dgrammatiko
Copy link
Copy Markdown
Contributor

@dgrammatiko dgrammatiko commented Aug 1, 2015

Let’s drop a few more gradients

Some FACTS:

  • Joomla is locked with Bootstrap 2.3.2
  • The less files are already touched multiple times
  • There’s not gonna be an update for BS 2.3.2
  • Joomla 3 is already 3 years old with the same template

With all those facts in mind I tried to drop a few more gradients so the rendered pages resemble a Bootstrap 3 template.
The changes are global since the less files touched here are the bootstrap 2.3.2 files
Changes affect only Isis template, the true impact is that 5 files are duplicated so changes in e.g. bootstrap buttons have to be done in two places, but since bootstrap is NOT gonna have any release for 2.3.x this is only theoretical, in practice we just have some duplicate less files to achieve our goal. Same goes for chosen, also notice that this version of chosen is dropping the png files and using icomoon which is always loaded for Isis...

B/C:

Other than the change in the appearance I don’t see any drawbacks here.

Preview:

screen shot 2015-08-01 at 15 01 41

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Aug 1, 2015

Spotted quite a few bugs

Drop Down menu items are invisible on hover
Text on Buttons like the Review Messages are unreadable
Toolbar buttons have no border/background (except on hover)

Finally the select boxes look the same as a disabled option

@dgrammatiko
Copy link
Copy Markdown
Contributor Author

dgrammatiko commented Aug 1, 2015

@brianteeman thanks, should be ok now

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7610.

@Bakual
Copy link
Copy Markdown
Contributor

Bakual commented Aug 1, 2015

Changing the Bootstrap LESS files will likely not be accepted due to B/C. You would be changing all templates that work from those. And they rightfully expect a Bootstrap 2.3.2 stack there.
The only changes we made to those files were needed to make it compatible with some MooTools stuff.
If you want to update Isis/Protostar, do it in the template folder itself. Don't touch the jui folders.
However I would argue that changing Protostar is not really a good idea as it affects productive sites all over the planet, changing their appearance quite a bit. Not everyone will think it's an improvement.
Isis is fine to change as it affects only administrators, not the public.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Aug 1, 2015

@DGT41 The issues I spotted with Isis are resolved.

Completely missed that you had updated protostar as well. I tend to agree with @Bakual on that one.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7610.

@dgrammatiko
Copy link
Copy Markdown
Contributor Author

dgrammatiko commented Aug 1, 2015

Redid this with overrides only for Isis

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Aug 2, 2015

Please test #7609 to solve another issue

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Aug 3, 2015

Updated title to remove reference to protostar

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7610.

@brianteeman brianteeman changed the title Visual update for isis-protostar Visual update for isis Aug 3, 2015
@ghazal
Copy link
Copy Markdown
Contributor

ghazal commented Aug 20, 2015

I have been using this Isis visual update on a few sites' backend and I quite like it.
One pb though, the dropdown of Modules position doesn't take into account the templates names.

OLD
old_isis
NEW
new_isis

@dgrammatiko
Copy link
Copy Markdown
Contributor Author

dgrammatiko commented Aug 20, 2015

@ghazal thanks for finding that. I pushed some changes, can you test them?

@dgrammatiko
Copy link
Copy Markdown
Contributor Author

dgrammatiko commented Sep 21, 2015

This is a UX/UI territory so I am gonna close and let them decide.

@dgrammatiko dgrammatiko deleted the ____ISIS_UI branch November 4, 2015 18:27
@dgrammatiko dgrammatiko mentioned this pull request Nov 7, 2015
Closed
@dgrammatiko dgrammatiko restored the ____ISIS_UI branch November 7, 2015 11:48
@dgrammatiko dgrammatiko reopened this Nov 7, 2015
@Gerlof
Copy link
Copy Markdown

Gerlof commented Nov 18, 2015

Color of 'delete icon' (grey, and black on hover) does not match with blue background of button. Grey on blue: low contrast.
pull-7610

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Nov 18, 2015

I guess this will need some changes in generatecss.php

@dgrammatiko
Copy link
Copy Markdown
Contributor Author

dgrammatiko commented Nov 21, 2015

@infograf768 actually it works great with generatecss.php (all the changes are in the template.less)

@ghost
Copy link
Copy Markdown

ghost commented Mar 9, 2016

Thanks for sharing your work, the JUX team will review and consider this idea.

@dgrammatiko dgrammatiko mentioned this pull request Mar 11, 2016
Closed
@dgrammatiko dgrammatiko mentioned this pull request Aug 25, 2016
Closed
@dgrammatiko dgrammatiko deleted the ____ISIS_UI branch October 11, 2016 11:36
@dgrammatiko dgrammatiko mentioned this pull request Feb 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@dgrammatiko @brianteeman @Bakual @infograf768 @ghazal @Gerlof @joomla-cms-bot