Skip to content

Correcting Isis dropdown z-index (see #7608)#7609

Merged
Kubik-Rubik merged 1 commit intojoomla:stagingfrom
infograf768:drop_zindex
Aug 3, 2015
Merged

Correcting Isis dropdown z-index (see #7608)#7609
Kubik-Rubik merged 1 commit intojoomla:stagingfrom
infograf768:drop_zindex

Conversation

@infograf768
Copy link
Copy Markdown
Member

As title says. See testing procedure in #7608

Before patch:
screen shot 2015-08-01 at 10 46 53

After patch:
screen shot 2015-08-01 at 11 47 00

@Fedik
Copy link
Copy Markdown
Member

Fedik commented Aug 2, 2015

not sure, maybe I missed something,
but for me here no issue, it works with old z-index value (tried in Chrome and Firefox in j3.4.4):
screen 2015-08-02 11 53 34 414x400

also I see that #status bar has z-index: 1030 https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/isis/css/template.css#L3339

@Fedik
Copy link
Copy Markdown
Member

Fedik commented Aug 2, 2015

UPD
I just tested on j 3.4.3 and there I got the described issue,
but seems it already fixed in 3.4.4 , in some way,
someone else can confirm?

ok, yes, it seems fixed:
in j3.4.3 #status has z-index: 1050;
in j3.4.4 #status has z-index: 1030;

@infograf768
Copy link
Copy Markdown
Member Author

This is not the z-index I get for the status bar. in edit module
It is z-index 1050 here:
screen shot 2015-08-02 at 11 09 39

@infograf768
Copy link
Copy Markdown
Member Author

My test is on 3.4.4 dev

@infograf768
Copy link
Copy Markdown
Member Author

Looks like the test has to be done on a multilang site.
inside the div status, we do have a div multiLangModal with class modal
That class contains z-index 1050
The code is there because the multilangstatus module is displayed

Therefore my PR solves the issue here and has no bad effect in monolanguage

@Fedik
Copy link
Copy Markdown
Member

Fedik commented Aug 2, 2015

hm, very strange, maybe I realy something missed
but you seen? https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/isis/css/template.css#L3339 it is 1030

@Fedik
Copy link
Copy Markdown
Member

Fedik commented Aug 2, 2015

ok, I understand 😄

@infograf768
Copy link
Copy Markdown
Member Author

One more tester!

@Fedik
Copy link
Copy Markdown
Member

Fedik commented Aug 2, 2015

I can reproduce the issue when enable module "Language status",
seems, this module add:

.navbar-fixed-bottom {
    z-index: 1050;
}

maybe we can just remove it there?

@Fedik
Copy link
Copy Markdown
Member

Fedik commented Aug 2, 2015

@Fedik
Copy link
Copy Markdown
Member

Fedik commented Aug 2, 2015

it was introduced in #4575 ... @DGT41 can you check is it still need there?

@infograf768
Copy link
Copy Markdown
Member Author

We need to keep the z-index 1050 in div modal as it is a bootstrap css
https://github.com/joomla/joomla-cms/blob/staging/media/jui/css/bootstrap.css#L6138-L6159

BTW, I took off the line here: https://github.com/joomla/joomla-cms/blob/staging/administrator/modules/mod_multilangstatus/tmpl/default.php#L15 and it does not work:

as the issue remains, It is easier imho to just increase the z-index as proposed in this PR.

@Fedik
Copy link
Copy Markdown
Member

Fedik commented Aug 2, 2015

ok, I just thought we can make "all in one place", for avoid confusing in future 😄

Current patch still good, anyway 😉

@infograf768
Copy link
Copy Markdown
Member Author

My mistake... changed code on another test site.

The issue is different if we take off that line in the multilangstatus module: it displays the modal all greyed

@dgrammatiko
Copy link
Copy Markdown
Contributor

Works ok here

@dgrammatiko
Copy link
Copy Markdown
Contributor

@Fedik the problem was that multilingual status modules is by default assigned to the bottom bar and the z-index made it unusable since the modal will remained hidden…. I didn’t realize at that time that this will backfire for chosen lists

@dgrammatiko
Copy link
Copy Markdown
Contributor

@infograf768 @Fedik shall we move multilane status from the bottom bar to cpanel? Will solve some inconsistencies, that still exist (e.g. reducing the browser width makes the modal go away)

@Fedik
Copy link
Copy Markdown
Member

Fedik commented Aug 2, 2015

@DGT41 for me it is fine where it is now 😉

@infograf768
Copy link
Copy Markdown
Member Author

Moving the multilanguagestatus module to CPanel was considered and rejected when we implemented this feature as ot may be needed at any time when working on multilang (setting languagefilter plugin, setting switcher module(s), setting content languages, setting Home menu items).

2 good tests: Please RTC for 3.4.4

@dgrammatiko
Copy link
Copy Markdown
Contributor

@infograf768 ahh ok, I didn’t know that

@infograf768
Copy link
Copy Markdown
Member Author

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7609.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 2, 2015
@Kubik-Rubik Kubik-Rubik added this to the Joomla! 3.4.4 milestone Aug 3, 2015
@Kubik-Rubik
Copy link
Copy Markdown
Member

Thank you, @infograf768!

Kubik-Rubik added a commit that referenced this pull request Aug 3, 2015
Correcting Isis dropdown z-index (see #7608)
@Kubik-Rubik Kubik-Rubik merged commit b1a5e0b into joomla:staging Aug 3, 2015
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 3, 2015
@infograf768 infograf768 deleted the drop_zindex branch August 3, 2015 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants