Skip to content

Update en-GB.tpl_beez3.ini#7360

Merged
rdeutz merged 4 commits intojoomla:stagingfrom
aaleksanyants:patch-1
Apr 12, 2016
Merged

Update en-GB.tpl_beez3.ini#7360
rdeutz merged 4 commits intojoomla:stagingfrom
aaleksanyants:patch-1

Conversation

@aaleksanyants
Copy link
Copy Markdown
Contributor

Updated template description

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Jul 7, 2015
@brianteeman
Copy link
Copy Markdown
Contributor

This changes the description from html 4 to html5

Is this template actually html5?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.

@aaleksanyants
Copy link
Copy Markdown
Contributor Author

yes it is :-)

@infograf768
Copy link
Copy Markdown
Member

Same string has to be changed in:
language/en-GB/en-GB.tpl_beez3.sys.ini

and in same files here:
templates/beez3/language/en-GB/en-GB.tpl_beez3.sys.ini
templates/beez3/language/en-GB/en-GB.tpl_beez3.ini

@aaleksanyants
Copy link
Copy Markdown
Contributor Author

Thank for pointing out the appropriate files in template folder, all files have been changed

@jwaisner
Copy link
Copy Markdown
Member

jwaisner commented Jul 8, 2015

@aaleksanyants

For testers, is there anything we should see different besides the strings being changed?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Jul 9, 2015

@jwaisner @aaleksanyants

For testers, is there anything we should see different besides the strings being changed?

No ;)

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Jul 9, 2015

If we get a ok by the en-GB WG we can move language files onky PRs to RTC ;)

@waader
Copy link
Copy Markdown
Contributor

waader commented Nov 7, 2015

I have tested this item ✅ successfully on 41a4704


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.

@brianteeman
Copy link
Copy Markdown
Contributor

By adding the version number for joomla this fails the style guide for the use of the joomla name https://joomla.github.io/user-interface-text/?user-interface-text/joomla_name_usage.md


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 41a4704


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.

@wojsmol
Copy link
Copy Markdown
Contributor

wojsmol commented Dec 28, 2015

@joomla-cms-bot
Copy link
Copy Markdown

This PR has received new commits.

CC: @andrepereiradasilva, @waader


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

I have not tested this item.

just a "!" so of course is tested ok


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.

@wojsmol
Copy link
Copy Markdown
Contributor

wojsmol commented Dec 28, 2015

@andrepereiradasilva Please mark on https://issues.joomla.org/tracker/joomla-cms/7360 as tested successfully.

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 1d2ba99


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.

sorry wrong box.
I know this can hardly be automated, but for this type of changes is it really need any other tests?

@brianteeman
Copy link
Copy Markdown
Contributor

Contacted Angie as the creator of the template to confirm the html5 change


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.

@brianteeman
Copy link
Copy Markdown
Contributor

Confirmed with Angie Setting RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 10, 2016
@joomla-cms-bot
Copy link
Copy Markdown

This PR has received new commits.

CC: @andrepereiradasilva, @waader


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 26f2759

Only updated the branch to latest staging. All equal.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.

@brianteeman brianteeman added this to the Joomla 3.5.1 milestone Mar 10, 2016
@brianteeman brianteeman modified the milestones: Joomla 3.5.1, Joomla 3.5.2 Mar 22, 2016
@brianteeman brianteeman removed this from the Joomla 3.5.1 milestone Mar 22, 2016
@rdeutz rdeutz merged commit df31e2f into joomla:staging Apr 12, 2016
@rdeutz rdeutz modified the milestones: Joomla 3.5.2, Joomla! 3.6.0 May 1, 2016
@brianteeman brianteeman removed the RTC This Pull Request is Ready To Commit label May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants