Regression: remaining code from #5140 breaks multilanguage#7159
Merged
Bakual merged 1 commit intojoomla:stagingfrom Jun 14, 2015
Merged
Regression: remaining code from #5140 breaks multilanguage#7159Bakual merged 1 commit intojoomla:stagingfrom
Bakual merged 1 commit intojoomla:stagingfrom
Conversation
Contributor
|
successfull This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7159. |
Member
|
PR tested successfully. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7159. |
Contributor
|
@test ok |
Member
Author
|
Please set RTC |
Bakual
pushed a commit
that referenced
this pull request
Jun 14, 2015
Regression: remaining code from #5140 breaks multilanguage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test, just install a new staging/master Joomla as a multilingual site.
Load frontend.
You will get and undefined index error because no cookie is set at that time.
Also, on an updated formally existing multilang site, any link to another language item which is not a direct menu link will get a wrong sef (and therefore 404) as the code fetches the cookie lang_code.
Patch and retest