Skip to content

Restructure JErrorPage to support PHP 7 exceptions#7065

Merged
wilsonge merged 1 commit intojoomla:3.5-devfrom
mbabker:PHP7ErrorPage
May 30, 2015
Merged

Restructure JErrorPage to support PHP 7 exceptions#7065
wilsonge merged 1 commit intojoomla:3.5-devfrom
mbabker:PHP7ErrorPage

Conversation

@mbabker
Copy link
Copy Markdown
Contributor

@mbabker mbabker commented May 30, 2015

This PR restructures JErrorPage, the class that is used as our global Exception handler, to support PHP 7. Specific changes:

  • Remove the typehinting for the render method
  • Test internal to the method for an Exception (PHP 5) or BaseException (PHP 7)
  • Add support to JDocumentError for the same
  • Wrap jexit in a function_exists check so that it can be mocked in our PHPUnit suite
  • Add unit tests to verify the PHP 7 behavior and the method's functionality when a non-Exception object is passed in

//cc @wilsonge

@dgrammatiko
Copy link
Copy Markdown
Contributor

dgrammatiko commented May 30, 2015

@test OK

forced error on /Users/dimitris/Documents/github_projects/joomla1/administrator/components/com_content/views/article/view.html.php
with code:
JError::raiseError(500, implode("\n", array('1' => 'some error'))); return false;
result:
screenshot 2015-05-30 17 24 00

@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented May 30, 2015

@test works fine. Merged. Thanks!

wilsonge added a commit that referenced this pull request May 30, 2015
@wilsonge
Merge pull request #7065 from mbabker/PHP7ErrorPage
1017801 
Restructure JErrorPage to support PHP 7 exceptions
@wilsonge wilsonge merged commit 1017801 into joomla:3.5-dev May 30, 2015
@wilsonge wilsonge added this to the Joomla! 3.5.0 milestone May 30, 2015
@stevenrombauts stevenrombauts mentioned this pull request Mar 4, 2016
Closed
johanjanssens added a commit to joomlatools/joomlatools-platform that referenced this pull request Mar 4, 2016
@johanjanssens
#247 - Port changes from Joomla CMS PR's
7d7d6b6 
 - joomla/joomla-cms#6600
 - joomla/joomla-cms#8340
 - joomla/joomla-cms#7198
 - joomla/joomla-cms#7065
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla! 3.5.0

Development

Successfully merging this pull request may close these issues.

5 participants

@mbabker @dgrammatiko @wilsonge @zero-24 @joomla-cms-bot