Fix for: zero or negative values on session lifetime.#6954
Fix for: zero or negative values on session lifetime.#6954maxvalentini77 wants to merge 3 commits intojoomla:stagingfrom maxvalentini77:fix-zero-negative-session-lifetime
Conversation
Setted a minimum of 1 to session lifetime.
How to test
Thanks @maxvalentini77 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6954. |
|
I think problem that there no backend validation for this input, same problem with "Cache Time" in same configuration form |
|
@maxvalentini77 I suggest to add |
|
@Fedik You are right, I'm working on a server side validation. |
|
Added number validator to check min/max range for number fields. |
|
RTC based on testing by @ChrisBreaks and @jonnyefftek on #jab15 #makeithappen This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6954. |
|
@test test resutls are: without patch applied, there's no error displayed and you can enter 0 inside "Session Lifetime " field. After applying the patch if you try to enter 0 as a value inside "Session Lifetime " field, you get this error: "Invalid field: Session Lifetime" This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6954. |
|
Merged with b649299 into Thanks! Is there a list of available JFormRules somewhere? If so that would need updated as we introduce a new one here. |
|
@Bakual Should the doc block say |
|
I wrote xx.x in the attribute because i didn't know in which version this class will be introduced. Now should contain 3.5.0, right? |
|
Correct @maxvalentini77 can you just send a quick PR that fixes that? |
|
Awww. I usually don't look at the doc blocks close enough... |

Zero or negative values on session lifetime
Session lifetime is an integer value and should be setted to a positive value greater than zero.