Skip to content

Tags - move Filters from left to [Search Tools]#6950

Closed
pe7er wants to merge 3 commits intojoomla:stagingfrom
pe7er:search-tools-tags
Closed

Tags - move Filters from left to [Search Tools]#6950
pe7er wants to merge 3 commits intojoomla:stagingfrom
pe7er:search-tools-tags

Conversation

@pe7er
Copy link
Copy Markdown
Contributor

@pe7er pe7er commented May 15, 2015

This PR moves the 3 Filter options of the Tags Manager to the [Search Tools] button.
note: The ordering dropdown in [Search Tools] needs to be fixed before merging.
(See Issue #6941 regarding the inconsistency with Filter options).

Test instructions

In back-end > Components > Tags
See the filters on the left (compare the position with filters in Content, Category & Menu components)

screen shot 2015-05-15 at 05 38 02

This PR changes moves the Filters

from the left to the middle column and will be visible when you click on the [Search Tools] button.

screen shot 2015-05-15 at 05 38 02

Notes:

I can use some help & suggestions regarding the following issues:

  • The ordering dropdown in [Search Tools] is currently not working
  • What to do with the empty slider? Add the "Tags" as title?
  • Code cleanup 1 - tmpl view ( /administrator/components/com_tags/views/tags/tmpl/default.php )
    contains "Joomla.orderTable = function()" that probably can be removed
  • Code cleanup 2 - In tmpl view (/administrator/components/com_tags/views/tags/view.html.php)
    I commented out the old filters in the left slider, they can be removed...
  • Code cleanup 3 - In tmpl view (/administrator/components/com_tags/views/tags/view.html.php) the function "protected function getSortFields()" can be removed as the ordering in [Search Tools] uses the "fullordering" specs from filter_tags.xml

@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label May 17, 2015
@pe7er
Copy link
Copy Markdown
Contributor Author

pe7er commented May 17, 2015

I've changed the component title from "Tags" to "Tags Manager",
and added a "Tags" submenu so that (although this component has just 1 view) the view is consistent with all other components.

screen shot 2015-05-17 at 08 40 03

Note: Sorting the results via the column headers works ok,
but the sorting option "Sort Table By:" (the dropdown) does not work yet.
I have not found a solution for that yet. I hope that someone can give me some pointers on that...


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6950.

@jduerscheid
Copy link
Copy Markdown

Issue successful tested! #jab15


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6950.

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented May 30, 2015

RTC based on testing 😄 #jab15 #makeithappen


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6950.

@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label May 30, 2015
@wilsonge wilsonge added this to the Joomla! 3.5.0 milestone Jun 6, 2015
@mbabker
Copy link
Copy Markdown
Contributor

mbabker commented Jul 11, 2015

Merged to 3.5-dev via b52f030

@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
@pe7er pe7er deleted the search-tools-tags branch November 5, 2015 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants