Skip to content

Add anchor css for menu item type of separator#6897

Closed
AteDev wants to merge 1 commit intojoomla:stagingfrom
AteDev:separatorAnchorClass
Closed

Add anchor css for menu item type of separator#6897
AteDev wants to merge 1 commit intojoomla:stagingfrom
AteDev:separatorAnchorClass

Conversation

@AteDev
Copy link
Copy Markdown
Contributor

@AteDev AteDev commented May 5, 2015

This PR add a field in menu item type of separator to give possibility to add anchor css (like component, url ...)

This PR add a field to give possibility to add anchor css for menu item
type of separator (like component, url ...)
@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented May 6, 2015

@test successful

How to test

  • apply the patch
  • add a new menu item with type Text Separator (can be found under System)
  • add a new class to the new field (e.g. red)
  • reload the frontend
  • use your dev tools (from your browser) to inspect the menu item
  • make sure the new class is added

@AteDev Thanks. PS: Please provide in the feature some kind of non tecnical testinstructions how to test. With it it will be easyier to test and understand your change 😄

@ghost
Copy link
Copy Markdown

ghost commented May 6, 2015

@test Success

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented May 6, 2015

RTC'ing Thanks 😄


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6897.

@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label May 6, 2015
@Kubik-Rubik Kubik-Rubik added this to the Joomla! 3.5.0 milestone May 9, 2015
@Kubik-Rubik
Copy link
Copy Markdown
Member

Thanks @AteDev for your contribution. Since this PR introduces a new feature, I've set the milestone to 3.5.

@zero-24 zero-24 added the Feature label May 9, 2015
@mbabker
Copy link
Copy Markdown
Contributor

mbabker commented Jul 11, 2015

Merged to 3.5-dev via 8d6246a

@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
@AteDev AteDev deleted the separatorAnchorClass branch August 21, 2016 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants