Moves GMail plugin to use the Joomla HTTP library#6692
Closed
wilsonge wants to merge 9 commits intojoomla:stagingfrom
Closed
Moves GMail plugin to use the Joomla HTTP library#6692wilsonge wants to merge 9 commits intojoomla:stagingfrom
wilsonge wants to merge 9 commits intojoomla:stagingfrom
Conversation
Contributor
|
@wilsonge i have just send you a PR: wilsonge#11 to fix codestyle. I will try to test now 😄 |
fixes a bit codestyle for joomla#6692
Contributor
|
@wilsonge on login with this patch applyed i get: |
Contributor
There was a problem hiding this comment.
Since JHttp still requires a Registry instance, we can cut the if part of this out and just have a foreach ($this->options->get('transport.curl', array()) as $key => $value) line here.
Contributor
Author
Contributor
|
@test This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6692. |
Contributor
|
Tested with all the options in the plugin and gmail authentication still works This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6692. |
Contributor
|
Setting RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6692. |
Contributor
|
Merged to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This utilises a framework PR (joomla-framework/http#12) to extend the transport options in Joomla for the SSL request. Currently to keep things incremental the plugin still only uses Curl, but in the future may allow to use other request methods that are available.
To test you can check that the Gmail authentication plugin still verifies users properly