Skip to content

make it mandatory to select a user before adding a user note#64

Closed
carson3511 wants to merge 2 commits intojoomla:masterfrom
carson3511:master
Closed

make it mandatory to select a user before adding a user note#64
carson3511 wants to merge 2 commits intojoomla:masterfrom
carson3511:master

Conversation

@carson3511
Copy link
Copy Markdown

Added some code to make it mandatory to select a user before a user note can be created. Currently the user note can be created without selecting a user and associating them with the note.

@infograf768
Copy link
Copy Markdown
Member

Please create a tracker on joomlacode for this to be tested.

@carson3511
Copy link
Copy Markdown
Author

@realityking
Copy link
Copy Markdown
Contributor

  1. Please don't use JParameter. It will be dropped in 3.0.
  2. Wouldn't adding required="true" to the XML definition of the user field have the same effect?
  3. I'm not sure what user notes are meant to be used for. Couldn't you need notes that don't always have users assigned to them?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Mike you need to clean this part up since we don't put in lines like this.

Chraneco pushed a commit to Chraneco/joomla-cms that referenced this pull request Mar 6, 2013
Fix for issue joomla#64 tags form field changed to tagnested.
@elinw
Copy link
Copy Markdown
Contributor

elinw commented Jul 7, 2013

Any update on this? Would be great to get some code for this.

@phproberto
Copy link
Copy Markdown
Contributor

I'm closing this as it's not mergeable and 2 years old. Feel free to open if you update it and are still interested in get it merged.

Thanks for contributing.

@phproberto phproberto closed this Oct 3, 2013
wilsonge pushed a commit that referenced this pull request Apr 7, 2016
Remove commented debug code
wilsonge pushed a commit that referenced this pull request Jan 23, 2017
laoneo pushed a commit to Digital-Peak/joomla-cms that referenced this pull request Oct 5, 2017
commit f866778a5326b4e1c3db10f578ac48c43c66c653
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Sat Sep 2 22:51:17 2017 +0300

    more changes

commit 4207db197419c8a098feb1d68ef07d2247301986
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Sat Sep 2 19:03:35 2017 +0300

    fix the routing

commit ddb59ac
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Fri Sep 1 16:12:38 2017 +0300

    fixes, remove webcomponets

commit 727401a
Merge: 1b1726d 6981a18
Author: Dimitri Grammatikogianni <mit505@upshift.gr>
Date:   Fri Sep 1 15:35:45 2017 +0300

    Merge pull request joomla#64 from ciar4n/style-postinstall

    Post install markup and style

commit 6981a18
Author: ciar4n <ciaran@joomla51.com>
Date:   Fri Sep 1 13:32:31 2017 +0100

    Post install markup and style

commit 1b1726d
Merge: 0a43128 42e5517
Author: Dimitri Grammatikogianni <mit505@upshift.gr>
Date:   Tue Aug 29 14:28:33 2017 +0300

    Merge pull request joomla#63 from ciar4n/style-preinstall

    New style to preinstall

commit 42e5517
Author: ciar4n <ciaran@joomla51.com>
Date:   Tue Aug 29 12:24:20 2017 +0100

    New style to preinstall check

commit 0a43128
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Wed Aug 23 16:37:18 2017 +0300

    js fixes

commit 9974ee5
Merge: 8fb5939 48857fc
Author: Dimitri Grammatikogianni <mit505@upshift.gr>
Date:   Tue Aug 22 19:53:31 2017 +0300

    Merge pull request joomla#62 from ciar4n/install-style

    Install re design

commit 48857fc
Author: ciar4n <ciaran@joomla51.com>
Date:   Tue Aug 22 17:50:20 2017 +0100

    Redesign

commit 8fb5939
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Sat Aug 19 18:24:35 2017 +0300

    remove duplicate line

commit 520b8d9
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Sat Aug 19 18:06:42 2017 +0300

    unmute sessions

commit 8f18075
Merge: 7b04a78 020ad0e
Author: Dimitri Grammatikogianni <mit505@upshift.gr>
Date:   Fri Jul 21 14:04:08 2017 +0300

    Merge pull request joomla#60 from ciar4n/install-style1

    Various bits

commit 7b04a78
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Fri Jul 21 13:42:13 2017 +0300

    clean up

commit 020ad0e
Author: ciar4n <ciaran@joomla51.com>
Date:   Fri Jul 21 11:24:58 2017 +0100

    Refactor alerts

commit 214db09
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Fri Jul 21 13:19:13 2017 +0300

    core needs patching

commit 2b5e924
Author: ciar4n <ciaran@joomla51.com>
Date:   Fri Jul 21 10:58:35 2017 +0100

    Compile SCSS

commit 3ffa406
Author: ciar4n <ciaran@joomla51.com>
Date:   Fri Jul 21 10:58:05 2017 +0100

    Add view/default.php

commit b0a580d
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Fri Jul 21 10:54:53 2017 +0300

    Use webcomponents for the alerts

commit 91272d2
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jul 20 20:53:07 2017 +0300

    easter egg, wow

commit a890a0b
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jul 20 19:45:12 2017 +0300

    do not fail

commit 00badb5
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jul 20 19:15:48 2017 +0300

    IIFE was a bad idea

commit 117426b
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jul 20 18:56:14 2017 +0300

    set focus to the rigth input between steps

commit 0df4e1b
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jul 20 18:44:59 2017 +0300

    smooth transitions in setup

commit 269d005
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jul 20 18:21:37 2017 +0300

    routing

commit 66b1cd7
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jul 20 15:28:20 2017 +0300

    better handling of the form

commit 8582cb6
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jul 20 14:39:05 2017 +0300

    recompile

commit e7135cf
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jul 20 14:24:36 2017 +0300

    session

commit 65bd548
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jul 20 14:08:10 2017 +0300

    styles

commit 2a41250
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Wed Jul 19 21:34:38 2017 +0300

    cleanup

commit 45a8af0
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Fri Jun 23 19:47:16 2017 +0300

    more

commit 405f799
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Tue Jun 6 11:36:50 2017 +0300

    morrere

commit 4eb2ef5
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Mon Jun 5 15:27:32 2017 +0300

    morerrererer

commit 6c3a285
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Sun Jun 4 13:55:25 2017 +0300

    morrrerer

commit faaca17
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jun 1 19:53:18 2017 +0300

    NOOOOOOOOOOOOOOOOOOOOOOOOO

commit 3eec79d
Merge: 4a91d2a d81f374
Author: Dimitri Grammatikogianni <mit505@upshift.gr>
Date:   Sun Jun 4 12:56:23 2017 +0200

    Merge pull request joomla#58 from ciar4n/animate-form

    Animate that form - fix header

commit d81f374
Author: ciar4n <ciaran@joomla51.com>
Date:   Thu Jun 1 17:56:25 2017 +0100

    Animate that form

commit 4a91d2a
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jun 1 17:26:00 2017 +0300

    more

commit 09d0ce8
Merge: 98eadea b058ea6
Author: Dimitri Grammatikogianni <mit505@upshift.gr>
Date:   Thu Jun 1 14:57:39 2017 +0200

    Merge pull request joomla#57 from ciar4n/form-split

    Form split

commit b058ea6
Merge: 97c32b4 98eadea
Author: Dimitri Grammatikogianni <mit505@upshift.gr>
Date:   Thu Jun 1 14:57:28 2017 +0200

    Merge branch '################4.0-dev-installation' into form-split

commit 97c32b4
Author: ciar4n <ciaran@joomla51.com>
Date:   Thu Jun 1 13:53:20 2017 +0100

    Split form

commit 98eadea
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jun 1 12:28:16 2017 +0300

    more

commit 14aa21c
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jun 1 12:28:16 2017 +0300

    more

commit e70bd5e
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Wed May 31 15:18:42 2017 +0300

    morrrrre

commit d38061a
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Wed May 31 11:34:24 2017 +0300

    more

commit b3730b7
Merge: e95fb4a 8d41267
Author: Dimitri Grammatikogianni <mit505@upshift.gr>
Date:   Wed May 31 10:34:59 2017 +0200

    Merge pull request joomla#56 from ciar4n/post-install-ftp

    Post install ftp & lang select to header

commit 8d41267
Author: ciar4n <ciaran@joomla51.com>
Date:   Wed May 31 09:32:29 2017 +0100

    Move lang select to header

commit 6803dd0
Author: ciar4n <ciaran@joomla51.com>
Date:   Tue May 30 18:22:59 2017 +0100

    Post install FTP options

commit e95fb4a
Merge: e143c1a 7519981
Author: Dimitri Grammatikogianni <mit505@upshift.gr>
Date:   Tue May 30 17:00:42 2017 +0200

    Merge pull request joomla#55 from ciar4n/password-icon

    Remove header margin - add password icon

commit 7519981
Author: ciar4n <ciaran@joomla51.com>
Date:   Tue May 30 15:57:15 2017 +0100

    Remove header margin - add password icon

commit e143c1a
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Tue May 30 17:24:48 2017 +0300

    preinstall

commit b8a55a7
Merge: a5213d6 1107db2
Author: Dimitri Grammatikogianni <mit505@upshift.gr>
Date:   Tue May 30 16:03:17 2017 +0200

    Merge pull request joomla#54 from ciar4n/install-style

    Installation layout and style

commit 1107db2
Author: ciar4n <ciaran@joomla51.com>
Date:   Tue May 30 14:58:16 2017 +0100

    install-style

commit a5213d6
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Tue May 30 15:54:33 2017 +0300

    1 col

commit 9e85f1c
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Tue May 30 13:11:34 2017 +0300

    markup

commit 55eebdc
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Mon May 29 12:18:39 2017 +0300

    init
laoneo pushed a commit to Digital-Peak/joomla-cms that referenced this pull request Oct 5, 2017
commit f866778a5326b4e1c3db10f578ac48c43c66c653
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Sat Sep 2 22:51:17 2017 +0300

    more changes

commit 4207db197419c8a098feb1d68ef07d2247301986
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Sat Sep 2 19:03:35 2017 +0300

    fix the routing

commit ddb59ac
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Fri Sep 1 16:12:38 2017 +0300

    fixes, remove webcomponets

commit 727401a
Merge: 1b1726d 6981a18
Author: Dimitri Grammatikogianni <mit505@upshift.gr>
Date:   Fri Sep 1 15:35:45 2017 +0300

    Merge pull request joomla#64 from ciar4n/style-postinstall

    Post install markup and style

commit 6981a18
Author: ciar4n <ciaran@joomla51.com>
Date:   Fri Sep 1 13:32:31 2017 +0100

    Post install markup and style

commit 1b1726d
Merge: 0a43128 42e5517
Author: Dimitri Grammatikogianni <mit505@upshift.gr>
Date:   Tue Aug 29 14:28:33 2017 +0300

    Merge pull request joomla#63 from ciar4n/style-preinstall

    New style to preinstall

commit 42e5517
Author: ciar4n <ciaran@joomla51.com>
Date:   Tue Aug 29 12:24:20 2017 +0100

    New style to preinstall check

commit 0a43128
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Wed Aug 23 16:37:18 2017 +0300

    js fixes

commit 9974ee5
Merge: 8fb5939 48857fc
Author: Dimitri Grammatikogianni <mit505@upshift.gr>
Date:   Tue Aug 22 19:53:31 2017 +0300

    Merge pull request joomla#62 from ciar4n/install-style

    Install re design

commit 48857fc
Author: ciar4n <ciaran@joomla51.com>
Date:   Tue Aug 22 17:50:20 2017 +0100

    Redesign

commit 8fb5939
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Sat Aug 19 18:24:35 2017 +0300

    remove duplicate line

commit 520b8d9
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Sat Aug 19 18:06:42 2017 +0300

    unmute sessions

commit 8f18075
Merge: 7b04a78 020ad0e
Author: Dimitri Grammatikogianni <mit505@upshift.gr>
Date:   Fri Jul 21 14:04:08 2017 +0300

    Merge pull request joomla#60 from ciar4n/install-style1

    Various bits

commit 7b04a78
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Fri Jul 21 13:42:13 2017 +0300

    clean up

commit 020ad0e
Author: ciar4n <ciaran@joomla51.com>
Date:   Fri Jul 21 11:24:58 2017 +0100

    Refactor alerts

commit 214db09
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Fri Jul 21 13:19:13 2017 +0300

    core needs patching

commit 2b5e924
Author: ciar4n <ciaran@joomla51.com>
Date:   Fri Jul 21 10:58:35 2017 +0100

    Compile SCSS

commit 3ffa406
Author: ciar4n <ciaran@joomla51.com>
Date:   Fri Jul 21 10:58:05 2017 +0100

    Add view/default.php

commit b0a580d
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Fri Jul 21 10:54:53 2017 +0300

    Use webcomponents for the alerts

commit 91272d2
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jul 20 20:53:07 2017 +0300

    easter egg, wow

commit a890a0b
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jul 20 19:45:12 2017 +0300

    do not fail

commit 00badb5
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jul 20 19:15:48 2017 +0300

    IIFE was a bad idea

commit 117426b
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jul 20 18:56:14 2017 +0300

    set focus to the rigth input between steps

commit 0df4e1b
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jul 20 18:44:59 2017 +0300

    smooth transitions in setup

commit 269d005
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jul 20 18:21:37 2017 +0300

    routing

commit 66b1cd7
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jul 20 15:28:20 2017 +0300

    better handling of the form

commit 8582cb6
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jul 20 14:39:05 2017 +0300

    recompile

commit e7135cf
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jul 20 14:24:36 2017 +0300

    session

commit 65bd548
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jul 20 14:08:10 2017 +0300

    styles

commit 2a41250
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Wed Jul 19 21:34:38 2017 +0300

    cleanup

commit 45a8af0
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Fri Jun 23 19:47:16 2017 +0300

    more

commit 405f799
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Tue Jun 6 11:36:50 2017 +0300

    morrere

commit 4eb2ef5
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Mon Jun 5 15:27:32 2017 +0300

    morerrererer

commit 6c3a285
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Sun Jun 4 13:55:25 2017 +0300

    morrrerer

commit faaca17
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jun 1 19:53:18 2017 +0300

    NOOOOOOOOOOOOOOOOOOOOOOOOO

commit 3eec79d
Merge: 4a91d2a d81f374
Author: Dimitri Grammatikogianni <mit505@upshift.gr>
Date:   Sun Jun 4 12:56:23 2017 +0200

    Merge pull request joomla#58 from ciar4n/animate-form

    Animate that form - fix header

commit d81f374
Author: ciar4n <ciaran@joomla51.com>
Date:   Thu Jun 1 17:56:25 2017 +0100

    Animate that form

commit 4a91d2a
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jun 1 17:26:00 2017 +0300

    more

commit 09d0ce8
Merge: 98eadea b058ea6
Author: Dimitri Grammatikogianni <mit505@upshift.gr>
Date:   Thu Jun 1 14:57:39 2017 +0200

    Merge pull request joomla#57 from ciar4n/form-split

    Form split

commit b058ea6
Merge: 97c32b4 98eadea
Author: Dimitri Grammatikogianni <mit505@upshift.gr>
Date:   Thu Jun 1 14:57:28 2017 +0200

    Merge branch '################4.0-dev-installation' into form-split

commit 97c32b4
Author: ciar4n <ciaran@joomla51.com>
Date:   Thu Jun 1 13:53:20 2017 +0100

    Split form

commit 98eadea
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jun 1 12:28:16 2017 +0300

    more

commit 14aa21c
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Thu Jun 1 12:28:16 2017 +0300

    more

commit e70bd5e
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Wed May 31 15:18:42 2017 +0300

    morrrrre

commit d38061a
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Wed May 31 11:34:24 2017 +0300

    more

commit b3730b7
Merge: e95fb4a 8d41267
Author: Dimitri Grammatikogianni <mit505@upshift.gr>
Date:   Wed May 31 10:34:59 2017 +0200

    Merge pull request joomla#56 from ciar4n/post-install-ftp

    Post install ftp & lang select to header

commit 8d41267
Author: ciar4n <ciaran@joomla51.com>
Date:   Wed May 31 09:32:29 2017 +0100

    Move lang select to header

commit 6803dd0
Author: ciar4n <ciaran@joomla51.com>
Date:   Tue May 30 18:22:59 2017 +0100

    Post install FTP options

commit e95fb4a
Merge: e143c1a 7519981
Author: Dimitri Grammatikogianni <mit505@upshift.gr>
Date:   Tue May 30 17:00:42 2017 +0200

    Merge pull request joomla#55 from ciar4n/password-icon

    Remove header margin - add password icon

commit 7519981
Author: ciar4n <ciaran@joomla51.com>
Date:   Tue May 30 15:57:15 2017 +0100

    Remove header margin - add password icon

commit e143c1a
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Tue May 30 17:24:48 2017 +0300

    preinstall

commit b8a55a7
Merge: a5213d6 1107db2
Author: Dimitri Grammatikogianni <mit505@upshift.gr>
Date:   Tue May 30 16:03:17 2017 +0200

    Merge pull request joomla#54 from ciar4n/install-style

    Installation layout and style

commit 1107db2
Author: ciar4n <ciaran@joomla51.com>
Date:   Tue May 30 14:58:16 2017 +0100

    install-style

commit a5213d6
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Tue May 30 15:54:33 2017 +0300

    1 col

commit 9e85f1c
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Tue May 30 13:11:34 2017 +0300

    markup

commit 55eebdc
Author: dgt41 <d.grammatiko@gmail.com>
Date:   Mon May 29 12:18:39 2017 +0300

    init
ciar4n pushed a commit to ciar4n/joomla-cms that referenced this pull request Oct 16, 2017
laoneo pushed a commit to Digital-Peak/joomla-cms that referenced this pull request May 14, 2018
…ts/components/com_config/tmpl/modules/default.php

Remove inline scripts/components/com config/tmpl/modules/default.php
wilsonge referenced this pull request in wilsonge/joomla-cms Apr 3, 2019
richard67 pushed a commit to richard67/joomla-cms that referenced this pull request Apr 3, 2020
richard67 pushed a commit to richard67/joomla-cms that referenced this pull request Apr 3, 2020
obuisard pushed a commit to obuisard/joomla-cms that referenced this pull request Feb 21, 2023
Fixes the width of the step table joomla#64
muhme pushed a commit to muhme/joomla-cms that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants