Skip to content

Let the com_installer manager helper follow our codestyle#6316

Merged
wilsonge merged 1 commit intojoomla:stagingfrom
zero-24:patch-15
Mar 5, 2015
Merged

Let the com_installer manager helper follow our codestyle#6316
wilsonge merged 1 commit intojoomla:stagingfrom
zero-24:patch-15

Conversation

@zero-24
Copy link
Copy Markdown
Contributor

@zero-24 zero-24 commented Mar 5, 2015

This PR let the com_installer manager helper follow our codestyle.

I don't think here is testing required. I hope this can be merged on Review by PLT / Maintainer 😄 Else let me know.

@infograf768
Copy link
Copy Markdown
Member

Just saw that you added a comma in the last part of the arrays (and also in your PR towards mine).
Are you sure this is correct?

-   'protected'
+   'protected',

@zero-24
Copy link
Copy Markdown
Contributor Author

zero-24 commented Mar 5, 2015

Just saw that you added a comma in the last part of the arrays (and also in your PR towards mine).
Are you sure this is correct?

Yes 😄

The comma after the last array element is optional and can be omitted. This is usually done for single-line arrays, i.e. array(1, 2) is preferred over array(1, 2, ). For multi-line arrays on the other hand the trailing comma is commonly used, as it allows easier addition of new elements at the end.

http://php.net/manual/en/language.types.array.php

and

When splitting array definitions onto several lines, the last value may also have a trailing comma. This is valid PHP syntax and helps to keep code diffs minimal.

http://joomla.github.io/coding-standards/?coding-standards/chapters/php.md

@infograf768
Copy link
Copy Markdown
Member

Great!

wilsonge added a commit that referenced this pull request Mar 5, 2015
Let the com_installer manager helper follow our codestyle
@wilsonge wilsonge merged commit 8889e46 into joomla:staging Mar 5, 2015
@wilsonge wilsonge added this to the Joomla! 3.4.1 milestone Mar 5, 2015
@zero-24 zero-24 deleted the patch-15 branch March 5, 2015 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants