CodeMirror 5.0 by okonomiyaki3000 · Pull Request #6150 · joomla/joomla-cms

okonomiyaki3000 · 2015-02-23T06:15:49Z

CodeMirror 5.0 is out and here it is. Please see http://codemirror.net/ for details. Basically, it might work on mobile now.

Also:

I'm minifying the mode files now which probably doesn't make that much difference but anyway...
Minified files are now *.min.js and *.min.css, uncompressed is *.js and *.css. Previously, the compressed version was simply *.js, *.css with uncompressed marked with '-uncompressed' which was kind of ugly.

infograf768 · 2015-02-23T07:07:29Z

The formatted name -uncompressed is specially used when debug is on. One should not get rid of it.

dgrammatiko · 2015-02-23T07:53:17Z

@infograf768 I think @okonomiyaki3000 has covered nicely this option

$ext = JFactory::getConfig()->get('debug') ? '.js' : '.min.js';

same thing goes for css, so no real worries for dropping the -uncompressed

infograf768 · 2015-02-23T07:54:25Z

Why would we? imho, better normalize.

Fedik · 2015-02-23T08:32:47Z

JHtml::_('script') will detect automatically debug mode, for uncompressed and for .min.js

so this $ext = JFactory::getConfig()->get('debug') ? '.js' : '.min.js'; do no need, just enough JHtml::_('script', 'pathto/script.min.js')

okonomiyaki3000 · 2015-02-23T08:38:33Z

For some time now, JHtml::script and JHtml::stylesheet have been able to swap .min.js and .min.css for their non-min counterparts when debug is on. So you basically have the option to use the .min way or the -uncompressed way. I'm choosing .min because it just seems like the better way of doing it (and it's kind of a defacto standard anyway).

The line of code that @DGT41 mentions is not using JHtml::script so I'm choosing the extension in a more direct way but I intend to remove this in the near future anyway.

okonomiyaki3000 · 2015-02-23T08:52:11Z

plugins/editors/codemirror/codemirror.php

See this change right here? Can't use JHtml::script for this. This string is a pattern used by CodeMirror to autoload the mode files. They all exists in both min and normal forms so we select which one we want and use it. Prior to this change, there was no minified version so it was not an issue.

brianteeman · 2015-03-05T18:53:34Z

This needs to be testes and merged quickly as this fixes a major issue with CodeMirror in the template manager (you can't type / )

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6150.}

Fedik · 2015-03-05T19:09:46Z

test show that it works (also type / fixed)
but I see milestone 3.5 😃

brianteeman · 2015-03-05T19:15:06Z

yes the milestone was before the serious bug was discovered

On 5 March 2015 at 19:09, Fedir Zinchuk notifications@github.com wrote:

test show that it works
but I see milestone 3.5 [image: 😃]

—
Reply to this email directly or view it on GitHub
#6150 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

FrankyDE · 2015-03-14T15:41:38Z

Without patch:
tested on iPad front and back-end everything works, so I am not sure if I can actually test the patch.
tested on iPhone 6 works fine too.
Side-Note: Code Mirror does not generate closing tag "

" if you use Swipe as a (non standard) keyboard, default keyboard works fine.

After Patch: Everything seems to work correctly

Test MacBook Pro: Successful
Test iPad Air 2 Successful
Test iPhone 6 Successful

brianteeman · 2015-03-14T15:45:04Z

@FrankyDE one easy test you can do is before the patch try to type a / it wont work. After the patch it will

tecpromotion · 2015-03-14T15:50:37Z

Test successfully. Works as expected.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6150.}

zero-24 · 2015-03-14T16:31:39Z

RTC based on testing! Thanks!

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6150.}

FrankyDE · 2015-03-14T17:04:33Z

thanks Brian, I tested that now without the patch and "/" does not display it simply vanishes.
Bug confirmed in iPad

Patch tested successful ! :-) #happy

CodeMirror 5.0

CodeMirror 5.0

3cdf39c

joomla-cms-bot added the PR-staging label Feb 23, 2015

This was referenced Feb 23, 2015

Code Mirror plugin improvements #5863

Merged

Include the Emmet plugin as a codemirror option. #5874

Closed

okonomiyaki3000 reviewed Feb 23, 2015
View reviewed changes

wilsonge added this to the Joomla! 3.5.0 milestone Feb 24, 2015

brianteeman mentioned this pull request Mar 3, 2015

Fix for Codemirror Cant Type Forward Slash #6280

Closed

infograf768 mentioned this pull request Mar 5, 2015

'/' Key Disabled in Template Editor #6313

Closed

wilsonge modified the milestones: Joomla! 3.4.1, Joomla! 3.5.0, Joomla! 3.4.2 Mar 10, 2015

brianteeman added the RTC This Pull Request is Ready To Commit label Mar 14, 2015

wilsonge added a commit that referenced this pull request Mar 17, 2015

Merge pull request #6150 from okonomiyaki3000/CodeMirrorUpdate

605f280

CodeMirror 5.0

wilsonge merged commit 605f280 into joomla:staging Mar 17, 2015

wilsonge added this to the Joomla! 3.4.1 milestone Mar 17, 2015

wilsonge removed this from the Joomla! 3.4.2 milestone Mar 17, 2015

zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015

Uh oh!

Conversation

okonomiyaki3000 commented Feb 23, 2015

Uh oh!

infograf768 commented Feb 23, 2015

Uh oh!

dgrammatiko commented Feb 23, 2015

Uh oh!

infograf768 commented Feb 23, 2015

Uh oh!

Fedik commented Feb 23, 2015

Uh oh!

okonomiyaki3000 commented Feb 23, 2015

Uh oh!

okonomiyaki3000 Feb 23, 2015

Choose a reason for hiding this comment

Uh oh!

brianteeman commented Mar 5, 2015

Uh oh!

Fedik commented Mar 5, 2015

Uh oh!

brianteeman commented Mar 5, 2015

Uh oh!

FrankyDE commented Mar 14, 2015

Uh oh!

brianteeman commented Mar 14, 2015

Uh oh!

tecpromotion commented Mar 14, 2015

Uh oh!

zero-24 commented Mar 14, 2015

Uh oh!

FrankyDE commented Mar 14, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants