Fix #5955: Search Engine Friendly URLs is not friendly to TOS article#5968
Merged
roland-d merged 1 commit intojoomla:stagingfrom Sep 8, 2015
joomdonation:patch-1
Merged
Fix #5955: Search Engine Friendly URLs is not friendly to TOS article#5968roland-d merged 1 commit intojoomla:stagingfrom joomdonation:patch-1
roland-d merged 1 commit intojoomla:stagingfrom
joomdonation:patch-1
Conversation
Contributor
There was a problem hiding this comment.
@joomdonation are you sure by removing this line?
How we handle it ($link) if no $tosarticle is set?
Contributor
Author
There was a problem hiding this comment.
Yes. That line of code is not used at all. In that block of code, if the article is not selected, it will go to the else block:
$link = $text;
Infact, when no article is selected, this tos field will be removed from the form https://github.com/joomla/joomla-cms/blob/staging/plugins/user/profile/profile.php#L265
So the code is correct.
Contributor
|
Tested successfully with SEF on and with URL rewriting on. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5968. |
Contributor
|
RTC based on the lastes tests Thanks. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5968. |
roland-d
added a commit
that referenced
this pull request
Sep 8, 2015
Fix #5955: Search Engine Friendly URLs is not friendly to TOS article
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see #5955 to understand the issue.
To test this PR:
a modal box with TOS article.