Fix minor b/c break in https://github.com/joomla/joomla-cms/pull/4292#5290
Merged
infograf768 merged 2 commits intojoomla:stagingfrom Dec 2, 2014
Merged
Fix minor b/c break in https://github.com/joomla/joomla-cms/pull/4292#5290infograf768 merged 2 commits intojoomla:stagingfrom
infograf768 merged 2 commits intojoomla:stagingfrom
Conversation
Contributor
|
@test success! |
Contributor
|
👍 Thanks @wilsonge for your great improvement in com_redirect, and the library, and your quick addressing of this little B/C! Keep up your great work, Joomla needs people like you 👍 |
Contributor
infograf768
added a commit
that referenced
this pull request
Dec 2, 2014
Fix minor b/c break in #4292
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a minor b/c break in #4292 where in some cases you could get the InvalidArgumentException being thrown when you got a 303 message.
Cases involved passing in empty string or null as the message parameter meaning the check at https://github.com/joomla/joomla-cms/pull/4292/files#diff-11a160a70413114ea70faf547cd097ecR976 failed and these values became the moved parameter (and weren't booleans or integers).
This adds a unit test for that scenario and fixes it. Of course all of this relates to the old redirect method and so of course is deprecated.