Initial codereview of languagefilter plugin#5135
Conversation
|
@Hackwar So far it seems to work nicely! |
|
This code review does not include the changes from #5129 yet. |
|
OK, got it: your 303 are those that are now 301 in #5129. |
|
Hannes, when you have time, give a look at #5129 (comment) and tell me if it is just a load of bullshit of mine or if there is any sense in it... |
|
Yeah, I know... Travis is a pain in the back... 😀 |
|
I combined this with #5129 and I looks like working |
|
Added #5129 to this PR. |
|
OK for me. |
|
Further changes are proposed in #5140 |
|
@infograf768 Thanks for asking, appreciated! I propose to implement the modification but at the same time have an option "Legacy redirect mode" to revert it in case anything "backfires". It should be plain easy: not even an "if" required, just use the option as the last parameter to $app->redirect() |
|
Sorry, but no. We are not going to introduce another parameter for this. This already will make no really measurable difference for Google. If you are concerned about your search engine ranking, then you have lots of other areas where you can work on. I doubt that the redirect type for this redirect makes more than 0.001% difference for Google. It will make more of a difference for Google that Joomla overall will become faster by an improved languagefilter plugin and that itself is only measurable in 2 digit milliseconds. |
|
OK, then let's cross fingers and hope it will not backfire in any way. |
|
Of course the best solution would be not having redirects at all, but probably this is not achievable with the current architecture. |
Initial codereview of languagefilter plugin
|
Merging and closing #5129 |
Change language string names Add extra large class to field Don't check for empty new url if in advanced mode Remove not null constraint in db Remove not null constraint in db (2/2) Add extra check for a 3xx code Port to all databases Add missing update files
|
Please see http://forum.joomla.org/viewtopic.php?f=711&t=882488&p=3292887#p3292887 |
This is an initial code review of the languagefilter plugin. There are several sins in this plugin and I tried to simplify and improve the code where possible.
Testing instructions are simple: