Conversation
This removes half of the JSession dependency in the method.
Use JSession to get the session ID
Update JSessionTest.php
…into sessionTests
|
Sorry George this didn’t work for me |
|
Ahh I'm so sorry. That's what comes of doing this on the plane and not checking through all the bugs I fixed on there. Fixed now. Sorry dude! |
|
That was fast 👍 |
|
That's because it was already fixed in my local branch :P |
|
Backend: tested most core stuff (menu, articles, categories, modules etc): all good! Big improvement in loading times in front end! 👍 Didn’t check with 3rd party apps So far @test is pass |
There was a problem hiding this comment.
delete this line (41) to make travis happy 😉
fd5a362 to
1d16bc0
Compare
|
Don't worry :) If that looks good to you then that makes me feel a lot more relieved :P |
There was a problem hiding this comment.
Just a suggestion, even when is not required I think is good if we follow the coding standards in tests too. For example this empty line should be removed.
There was a problem hiding this comment.
Whipped through them quickly. Think I've covered most your points :)
libraries/joomla/factory.php
Outdated
There was a problem hiding this comment.
Why the f**k do we have a reference to "editor" here? 😉
There was a problem hiding this comment.
It looks like the comment is wrong, not the code :D
|
@test OK In an OAuth2 authorization workflow, internal information is saved in JSession. User leaves the site and after the external authorization step, the information is retrieved from JSession to complete the auth token retrieval. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5088. |
|
RTC based on testing by @anibalsanchez and @compojoom Thanks! This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5088. |
|
@wilsonge can you update the |
|
So, as an additional validation on this PR, using the new |
Session PR update
|
Merged to |
This allows JSession to be unit testable and provides an interface similar to that in Symfony to allow injection of sessions into the CMS.
It should be b/c for users however so far all I've been able to do is test stuff with core extensions. If you are doing anything outside of core that uses JSession please do test it or let me know of your application!