Skip to content

[5.4] Update deleted files and folders in script.php for the upcoming 5.4.3 release#46830

Merged
muhme merged 2 commits intojoomla:5.4-devfrom
richard67:5.4-dev-deleted-files-and-folders-2026-02-04
Feb 4, 2026
Merged

[5.4] Update deleted files and folders in script.php for the upcoming 5.4.3 release#46830
muhme merged 2 commits intojoomla:5.4-devfrom
richard67:5.4-dev-deleted-files-and-folders-2026-02-04

Conversation

@richard67
Copy link
Copy Markdown
Member

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the lists of files and folders to be deleted on update in script.php for the upcoming 5.4.3 release.

All files and folders added by this PR here are testing files from symfony composer dependencies, see PR #46765 for the removal of these files and folders from the package build.

Testing Instructions

Code review.

Or compare the full installation zip package created by Drone for this PR (or any other 5.4-dev PR after the merge of PR #46765 or from tomorrow on you can also use the latest 5.4-dev nightly build) with the full installation zip package of 5.4.2 and check which files and folders only exist in the 5.4.2 package-

Or update from 5.4.2 to the latest 5.4 nightly build to check the actual result, and update from 5.4.2 to the patched update package or custom update URL created by Drone for this PR here to check the expected result.

Actual result BEFORE applying this Pull Request

After an update from 5.4.2 to the latest 5.4 nightly build, the files and folders handled in this PR are still there.

Expected result AFTER applying this Pull Request

After an update from 5.4.2 to the patched update package or custom update URL created by Drone for this PR here, the files and folders handled in this PR have been deleted.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on dacf1d9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46830.

@brianteeman
Copy link
Copy Markdown
Contributor

@richard67 can the script you used for this be added to the build folder and process to avoid the bus factor


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46830.

@richard67
Copy link
Copy Markdown
Member Author

@richard67 can the script you used for this be added to the build folder and process to avoid the bus factor
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46830.

@brianteeman The script is not ready yet as it still requires some manual adjustments to the code after using it. I hope to find the time latest when my term of duty as release manager for 5.4-dev will end, so it can be used in automated actions.

@muhme
Copy link
Copy Markdown
Contributor

muhme commented Feb 4, 2026

I have tested this item ✅ successfully on 9581dec

Tested with JBT and in extracting the full packages:

  • Tested php cli/joomla.php update:joomla:remove-old-files before PR
    • 0 files and 0 folders are deleted
  • Found 9 files and 6 directories
    jbt-54 # find . -type f | grep '/Test/'
    ./libraries/vendor/symfony/validator/Test/ConstraintValidatorTestCase.php
    ./libraries/vendor/symfony/translation-contracts/Test/TranslatorTest.php
    ./libraries/vendor/symfony/var-dumper/Test/VarDumperTestTrait.php
    ./libraries/vendor/symfony/http-client/Test/HarFileResponseFactory.php
    ./libraries/vendor/symfony/service-contracts/Test/ServiceLocatorTestCase.php
    ./libraries/vendor/symfony/service-contracts/Test/ServiceLocatorTest.php
    ./libraries/vendor/symfony/http-client-contracts/Test/TestHttpServer.php
    ./libraries/vendor/symfony/http-client-contracts/Test/HttpClientTestCase.php
    ./libraries/vendor/symfony/http-client-contracts/Test/Fixtures/web/index.php
    
    jbt-54 # find . -name Test -type d
    ./libraries/vendor/symfony/validator/Test
    ./libraries/vendor/symfony/translation-contracts/Test
    ./libraries/vendor/symfony/var-dumper/Test
    ./libraries/vendor/symfony/http-client/Test
    ./libraries/vendor/symfony/service-contracts/Test
    ./libraries/vendor/symfony/http-client-contracts/Test
    
  • Applied PR with gh pr checkout 46830
    • running again and 9 files and 8 folders are deleted (two more as sub-folders)
    • running 3rd time, again 0 files and 0 folders are deleted
  • Testing for other files and directories, unzipped PR full package as 543/ and 5.4.2 full release package as 542/
    • Compared
    ( cd 542 ; find . -print | sort > /tmp/542.txt )
    ( cd 543 ; find . -print | sort > /tmp/543.txt )
    diff /tmp/542.txt /tmp/543.txt
    
    • Seen again only the 6 folders, plus 2 sub-folders and the 9 files

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46830.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 5.4.3 milestone Feb 4, 2026
@muhme
Copy link
Copy Markdown
Contributor

muhme commented Feb 4, 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46830.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 4, 2026
@muhme muhme merged commit 9a14073 into joomla:5.4-dev Feb 4, 2026
189 of 204 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 4, 2026
@muhme muhme added this to the Joomla! 5.4.3 milestone Feb 4, 2026
@muhme
Copy link
Copy Markdown
Contributor

muhme commented Feb 4, 2026

Thank you @richard67 for your contribution. Thank you @brianteeman for testing.

@richard67 richard67 deleted the 5.4-dev-deleted-files-and-folders-2026-02-04 branch February 4, 2026 17:44
sathwikre pushed a commit to sathwikre/joomla-cms that referenced this pull request Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants