Skip to content

[6.0] Language cache error handling improvement#46545

Merged
Bodge-IT merged 4 commits intojoomla:6.0-devfrom
joomdonation:language_cache_error_handling
Jan 14, 2026
Merged

[6.0] Language cache error handling improvement#46545
Bodge-IT merged 4 commits intojoomla:6.0-devfrom
joomdonation:language_cache_error_handling

Conversation

@joomdonation
Copy link
Copy Markdown
Contributor

@joomdonation joomdonation commented Dec 7, 2025

Pull Request for Issue # .

Summary of Changes

This PR improves the robustness of Joomla’s language cache handling. Currently, if a language cache file is only partially written (e.g., due to low disk space, write interruption, or unexpected I/O failure), the corrupted cache file will remain on disk. On the next request, Joomla attempts to include this broken file, which may lead to PHP errors, warnings, or unexpected behavior.

This PR introduces safer handling of such scenarios by:

  • Removing the corrupted cache file immediately when the write operation fails, ensuring Joomla does not load an invalid cache file in future requests.
  • Logging the failure so administrators can see errors from log if needed.

Testing Instructions

I could not find an easy way to make this operation fail on normal condition. So you can just perform simple test below:

  • Use Joomla 6.0
  • Apply patch
  • Delete language cache folder (administrator\cache\language)
  • Access to your site again, make sure there is no error
  • Check language cache folder (administrator\cache\language) and make sure the cache files still being created as before.

Actual result BEFORE applying this Pull Request

Works, with potential errors if cache file is partially written

Expected result AFTER applying this Pull Request

Works, no potential errors

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-6.0-dev labels Dec 7, 2025
@exlemor
Copy link
Copy Markdown

exlemor commented Dec 8, 2025

I have tested this item ✅ successfully on 7fa9554

I have successfully tested this.

(In case this is important (I doubt it): when going back into the backend and clicking around, the number of cache files that come back into the administrator/cache/language directory is not always the same initially...) most of the time it's 78 or 90, but sometimes its 58, and eventually climbs up to 120.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46545.

@muhme
Copy link
Copy Markdown
Contributor

muhme commented Dec 13, 2025

Tested with JBT

  • Seen the problem before: File language-en-GB-mod_login.ini.*.php has been partially deleted and the site fails with 500 and stack trace
  • Installed from PR's full package
    • ✅ Deleted all files in administrator\cache\language and used files are recreated on next load
    • Inserted throw new FilesystemException('Debug exception'); before line 501 to test the catch block
      • The first entry is untranslated, as the translation is not cache-loaded, right?
      • ⚠️ But, I am wondering for 19 written cache files, there are only 10 log entries? Why?
Listings

20 files are created:

ls -1 administrator/cache/language
administrator-language-en-GB-com_content.ini.1765117314.php
administrator-language-en-GB-plg_actionlog_joomla.ini.1765117314.php
administrator-language-en-GB-plg_system_debug.ini.1765117314.php
administrator-language-en-GB-plg_task_checkfiles.ini.1765117314.php
administrator-language-en-GB-plg_task_deleteactionlogs.ini.1765117314.php
administrator-language-en-GB-plg_task_globalcheckin.ini.1765117314.php
administrator-language-en-GB-plg_task_privacyconsent.ini.1765117314.php
administrator-language-en-GB-plg_task_requests.ini.1765117314.php
administrator-language-en-GB-plg_task_rotatelogs.ini.1765117314.php
administrator-language-en-GB-plg_task_sessiongc.ini.1765117314.php
administrator-language-en-GB-plg_task_sitestatus.ini.1765117314.php
administrator-language-en-GB-plg_task_updatenotification.ini.1765117314.php
language-en-GB-com_ajax.ini.1765117314.php
language-en-GB-com_content.ini.1765117314.php
language-en-GB-joomla.ini.1765117314.php
language-en-GB-lib_joomla.ini.1765117314.php
language-en-GB-mod_breadcrumbs.ini.1765117314.php
language-en-GB-mod_login.ini.1765117314.php
language-en-GB-mod_menu.ini.1765117314.php
language-en-GB-tpl_cassiopeia.ini.1765117314.php

But only 10 log entries?

$ cat administrator/logs/everything.php 
#
#<?php die('Forbidden.'); ?>
#Date: 2025-12-13 16:26:39 UTC
#Software: Joomla! 6.0.2-dev+pr.46545 Development [ Kuimarisha ] 25-November-2025 17:01 UTC

#Fields: datetime	priority	clientip	category	message
2025-12-13T16:41:02+00:00	WARNING	3.160.39.15	language	JLIB_LANGUAGE_ERROR_CANNOT_WRITE_CACHE
2025-12-13T16:41:02+00:00	WARNING	3.160.39.15	language	Unable to write cache file for /administrator/cache/language/administrator-language-en-GB-plg_actionlog_joomla.ini.1765117314.php.
2025-12-13T16:41:02+00:00	WARNING	3.160.39.15	language	Unable to write cache file for /administrator/cache/language/language-en-GB-tpl_cassiopeia.ini.1765117314.php.
2025-12-13T16:41:02+00:00	WARNING	3.160.39.15	language	Unable to write cache file for /administrator/cache/language/language-en-GB-com_content.ini.1765117314.php.
2025-12-13T16:41:02+00:00	WARNING	3.160.39.15	language	Unable to write cache file for /administrator/cache/language/language-en-GB-mod_menu.ini.1765117314.php.
2025-12-13T16:41:02+00:00	WARNING	3.160.39.15	language	Unable to write cache file for /administrator/cache/language/language-en-GB-mod_login.ini.1765117314.php.
2025-12-13T16:41:02+00:00	WARNING	3.160.39.15	language	Unable to write cache file for /administrator/cache/language/language-en-GB-mod_breadcrumbs.ini.1765117314.php.
2025-12-13T16:41:02+00:00	WARNING	3.160.39.15	language	Unable to write cache file for /administrator/cache/language/administrator-language-en-GB-com_content.ini.1765117314.php.
2025-12-13T16:41:02+00:00	WARNING	3.160.39.15	language	Unable to write cache file for /administrator/cache/language/administrator-language-en-GB-plg_system_debug.ini.1765117314.php.
2025-12-13T16:46:04+00:00	WARNING	3.160.39.15	language	Unable to write cache file for /administrator/cache/language/language-en-GB-com_ajax.ini.1765117314.php.

@joomdonation Can you reproduce this or do you have an explanation for it? I would like to proceed with an issue tracker test.

@joomdonation
Copy link
Copy Markdown
Contributor Author

joomdonation commented Dec 19, 2025

@muhme So you are saying that in your case, number of cache files is not the same with number of log entries? If so, I could not reproduce that issue. And in case logging is not working for some reasons, it is also un-related to this PR.

@muhme
Copy link
Copy Markdown
Contributor

muhme commented Dec 28, 2025

@joomdonation

I could not reproduce that issue ... it is also un-related to this PR

Thank you for checking 👍

@muhme
Copy link
Copy Markdown
Contributor

muhme commented Dec 28, 2025

I have tested this item ✅ successfully on 7fa9554

Current 6.0-dev Re-Test with JBT

  • Note: As the created files are depending of the system activites, I didn't used backend login, simple waited > 60 seconds as JBT runs scheduler crontab based every minute
  • Before PR: Deleted all administrator/cache/language/ files, counted and saved 10 created language cache files
  • Applied PR with gh pr checkout 46545, deleted all administrator/cache/language/ files
  • Found and compared identical 10 language cache files created
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46545.

@richard67
Copy link
Copy Markdown
Member

richard67 commented Dec 29, 2025

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46545.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 29, 2025
@Bodge-IT Bodge-IT merged commit 3c6461a into joomla:6.0-dev Jan 14, 2026
51 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 14, 2026
@Bodge-IT
Copy link
Copy Markdown
Contributor

Bodge-IT commented Jan 14, 2026

Thanks @joomdonation for the fix, and to all the testers who made it possible.

@Bodge-IT Bodge-IT added this to the Joomla! 6.0.3 milestone Jan 14, 2026
@joomdonation joomdonation deleted the language_cache_error_handling branch January 14, 2026 10:51
@jgerman-bot jgerman-bot mentioned this pull request Jan 15, 2026
Closed
@joomlapl-bot joomlapl-bot mentioned this pull request Jan 15, 2026
Open
Kostelano added a commit to JPathRu/localisation that referenced this pull request Apr 20, 2026
@Kostelano
Новое в Joomla 6.0.4 Stable
4926820 
6.0.2
joomla/joomla-cms#46593 + (upmerge)

6.0.3
joomla/joomla-cms#46763 + (upmerge)
joomla/joomla-cms#46828 + (upmerge)
joomla/joomla-cms#46686 + (upmerge)
joomla/joomla-cms#46545 +

6.0.4
joomla/joomla-cms#47398 +
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Language Change This is for Translators PR-6.0-dev

Projects

None yet

Milestone

Joomla! 6.0.3

Development

Successfully merging this pull request may close these issues.

6 participants

@joomdonation @exlemor @muhme @richard67 @Bodge-IT @joomla-cms-bot