[5.4] [webservices] Create a user access level via POST#46080
[5.4] [webservices] Create a user access level via POST#46080muhme merged 13 commits intojoomla:5.4-devfrom
Conversation
|
Would you mind to add a system test for it? |
|
added some system test |
|
This pull request has been automatically rebased to 5.4-dev. |
|
I have tested this item ✅ successfully on 0767cb6 Details: After Patch: Details: |
|
I have tested this item ✅ successfully on 0767cb6 I met the BEFORE condition and { and then, I wondered what would happen if I re-tried the POST command once it was created? { I am mentioning it because I figured it might help, if that is expected and in that form/format - than perfecto! :) Also, after having done a POST, I did a GET and the new access level above appears so :D This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46080. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46080. |
|
I have tested this item 🔴 unsuccessfully on e85b984 ❌ Final test before merge with JBT
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46080. |
|
Removed RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46080. |
|
For documentation: To create a new user access entry via POST it is not needed to set |
|
@muhme can you share the payload that you use with PATCH, and also what it is the crash
cause i'm not able to reproduce
|
Thank you for working on this PR. I used e.g.
This request is working before and after PR. But it stores New tested: It is also possible to use a letter e.g. "X". The letter is stored in the database and furthermore ignored. |
|
the correct way to create a PATCH payload for rules should be {
"title": "bbTechnician",
"rules": "[1]"
}like in the GET response {
"links": {
"self": "https://localhost:80/api/index.php/v1/users/levels/3"
},
"data": {
"type": "levels",
"id": "3",
"attributes": {
"id": 3,
"title": "Special",
"rules": [
6,
3,
8
]
}
}
}verifying the correct payload is out of scope of this PR |
|
I have tested this item ✅ successfully on 9b97de7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46080. |
|
I've restored the previous human test results in the issue tracker as the commits which have invalidated the tests were just clean branch update and the addition of a test case for system tests. @muhme Could you review your unsuccessful test result with respect to @alikon 's comment above? Thanks in advance. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46080. |
|
Thank you @alikon for your contribution. Thank you @laoneo for support. Thank you @Razzo1987, @exlemor and @rutuja123242 for testing. |
|
@alikon Unfortunately we had to revert this PR yesterday because we were building the 5.4.3-rc1 and 6.0.3-rc1 yesterday and we had found a small issue in your PR after it was merged which we have missed before:
We would be happy if you could redo your PR but without the removal of the Sorry for the inconvenience, and thanks for your contribution, and thanks in advance for the new PR. |


Pull Request for Issue #45971.
Summary of Changes
fixed form level.xml
Testing Instructions
use the POST with `` endpoint
/api/index.php/v1/users/levelswith this payload to create a User Access LevelActual result BEFORE applying this Pull Request
HTTP 400 Bad request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed