Skip to content

[5.4] Fix fields menu items in preset#46062

Merged
muhme merged 2 commits intojoomla:5.4-devfrom
brianteeman:alternate_menu_preset
Sep 11, 2025
Merged

[5.4] Fix fields menu items in preset#46062
muhme merged 2 commits intojoomla:5.4-devfrom
brianteeman:alternate_menu_preset

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

@brianteeman brianteeman commented Sep 10, 2025

Summary of Changes

Missing view in the list fields menu item

Testing Instructions

Create a custom admin menu and import the alternate preset
In the menu manager check the User Fields and the Article Fields menu items.
In the menu manager check the User Field Groups and the Article Field groups menu items.

Actual result BEFORE applying this Pull Request

The Menu Item Type is empty
image

Expected result AFTER applying this Pull Request

The Menu Item Type is correct
image

NOTE

  1. The context field is also empty both with and without this PR - that is resolved by [5.4] NPM audit fix security vulnerabilities in indirect development dependencies 2025-11-26 #46502 by @SniperSister
  2. The menu link works both with and without this PR due to a quirk the the default view is loaded when not specified
  3. This is a bug fix but made against 5.4 as [5.4] NPM audit fix security vulnerabilities in indirect development dependencies 2025-11-26 #46502 is also against 5.4

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Missing view in the list fields menu item

Create a custom admin menu and import the alternate preset
In the menu manager check the User Fields and the Article Fields menu items. The Menu Item Type is empty
In the menu manager check the User Field Groups and the Article Field groups menu items.
The Menu Item Type is correct

Delete the custom admin menu And repeat the steps above
The Menu Item Type is now correct

[note the context is empty - this is fixed by 46052]

Signed-off-by: BrianTeeman <brian@teeman.net>
@SniperSister
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on b284d5f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46062.

1 similar comment
@richard67
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on b284d5f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46062.

@richard67
Copy link
Copy Markdown
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46062.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 10, 2025
@richard67 richard67 added the bug label Sep 10, 2025
@muhme
Copy link
Copy Markdown
Contributor

muhme commented Sep 11, 2025

✅ Final test before merge with JBT

  • Problem with Users > Fields and Content > Fields seen with nightly build
  • Fix seen with PRs full package and additional checked links are still working

@muhme muhme merged commit e4977da into joomla:5.4-dev Sep 11, 2025
40 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 11, 2025
@muhme muhme added this to the Joomla! 5.4.0 milestone Sep 11, 2025
@muhme
Copy link
Copy Markdown
Contributor

muhme commented Sep 11, 2025

Thank you @brianteeman for your contribution. Thank you @SniperSister and @richard67 for testing.

dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants