Or use the form field type="headertag" instead of all the Options?

@chmst headertag is for the module title. This pr is for the article title

I know, but we could use the form field everywhere - it simply generates the options for headings.
https://github.com/joomla/joomla-cms/blob/5.3-dev/libraries/src/Form/Field/HeadertagField.php

I have tested this item ✅ successfully on c327cdd

Makes sense

@chmst I don't see how that's helpful in this use case. If we let you select h5 what's wrong with being able to select h6

Our global administrator language file has language strings JH1 to JH6: https://github.com/joomla/joomla-cms/blob/5.4-dev/administrator/language/en-GB/joomla.ini#L35-L40

I see no reason why not to use all 6.

Only question is why not do the other modules, too?

• https://github.com/joomla/joomla-cms/blob/5.4-dev/modules/mod_articles_categories/mod_articles_categories.xml#L128-L141
• https://github.com/joomla/joomla-cms/blob/5.4-dev/modules/mod_articles_news/mod_articles_news.xml#L100-L113

The latter is legacy so maybe that should not be changed.

But the former still seems to be state of the art (not legacy) so that could be changed, too.

@brianteeman What do you think? Change these 2, too? Or only the former?

For consistency you are correct they should be changed. I leave it to the maintainers to decide if the legacy module should be updated or not.

I have tested this item ✅ successfully on c327cdd

RTC

Final test before merge with JBT graft nightly build and full package from PR
✅ Seen h1 - h5 before, seen h6 after, checked HTML source code

Notes:

• The 'Display Options > Header Level' is used for the article links, not for the module header (which is 'Advanced > Header Tag')
• In 'Advanced > Header Tag' you already can choose h6.
• In 'Advanced > Header Tag' you can also choose 'p' and 'div'.
  • For individual styling in 'Display Options > Header Level' you can choose the div's with class name.
• But could uniform usage of header selection still be useful?

Thank you @travisrisner for your contribution. Thank you @brianteeman, @richard67 and @chmst for your comments. Thank you @brianteeman and @mothershedc for testing.